netdev - Re: [PATCH 2/4] mfd: intel-lpss: Utilize i2c-designware.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6646b690-7b05-4a0e-a524-375b389ad591@broadcom.com>
Date: Thu, 2 May 2024 09:19:42 -0700
From: Florian Fainelli <florian.fainelli@...adcom.com>
To: Lee Jones <lee@...nel.org>
Cc: Andy Shevchenko <andy.shevchenko@...il.com>,
 linux-kernel@...r.kernel.org, Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
 Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 Mika Westerberg <mika.westerberg@...ux.intel.com>,
 Jan Dabros <jsd@...ihalf.com>, Andi Shyti <andi.shyti@...nel.org>,
 Jiawen Wu <jiawenwu@...stnetic.com>, Mengyuan Lou
 <mengyuanlou@...-swift.com>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>,
 Maciej Fijalkowski <maciej.fijalkowski@...el.com>,
 Andrew Lunn <andrew@...n.ch>, Duanqiang Wen <duanqiangwen@...-swift.com>,
 "open list:SYNOPSYS DESIGNWARE I2C DRIVER" <linux-i2c@...r.kernel.org>,
 "open list:WANGXUN ETHERNET DRIVER" <netdev@...r.kernel.org>
Subject: Re: [PATCH 2/4] mfd: intel-lpss: Utilize i2c-designware.h

On 5/2/24 00:17, Lee Jones wrote:
> On Tue, 23 Apr 2024, Florian Fainelli wrote:
> 
>>
>>
>> On 4/23/2024 5:00 PM, Andy Shevchenko wrote:
>>> Tue, Apr 23, 2024 at 04:36:20PM -0700, Florian Fainelli kirjoitti:
>>>> Rather than open code the i2c_designware string, utilize the newly
>>>> defined constant in i2c-designware.h.
>>>
>>> ...
>>>
>>>>    static const struct mfd_cell intel_lpss_i2c_cell = {
>>>> -	.name = "i2c_designware",
>>>> +	.name = I2C_DESIGNWARE_NAME,
>>>>    	.num_resources = ARRAY_SIZE(intel_lpss_dev_resources),
>>>>    	.resources = intel_lpss_dev_resources,
>>>>    };
>>>
>>> We have tons of drivers that are using explicit naming, why is this case
>>> special?
>>>
>>
>> It is not special, just one of the 3 cases outside of drivers/i2c/busses
>> that reference a driver living under drivers/i2c/busses, as I replied in the
>> cover letter, this is a contract between the various device drivers and
>> their users, so we should have a central place where it is defined, not
>> repeated.
> 
> I have always held the opinion that replacing user-facing strings with
> defines harms debugability, since grepping becomes a multi-stage
> process, often with ambiguous results (in the case of multiple
> definitions with the same name.  Please keep the string in-place.

I am not buying into that argument and the fact that Duangiang was able 
to trip over the lack of an explicit contract between drivers seems like 
a bigger obstacle than doing a multi-stage grep. Anyway, I have no skin 
in this game, I just don't like seeing repetition and not stating 
contracts between drivers more explicitly.
-- 
Florian

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4221 bytes)