netdev - Re: [PATCH net] phonet: fix rtm_phonet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5716887.zLmFTfJpZe@basile.remlab.net>
Date: Thu, 02 May 2024 20:34:00 +0300
From: Rémi Denis-Courmont <remi@...lab.net>
To: "David S . Miller" <davem@...emloft.net>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Eric Dumazet <edumazet@...gle.com>
Cc: netdev@...r.kernel.org, eric.dumazet@...il.com,
 Eric Dumazet <edumazet@...gle.com>, Remi Denis-Courmont <courmisch@...il.com>
Subject: Re: [PATCH net] phonet: fix rtm_phonet_notify() skb allocation

Le torstaina 2. toukokuuta 2024, 19.17.00 EEST Eric Dumazet a écrit :
> fill_route() stores three components in the skb:
> 
> - struct rtmsg
> - RTA_DST (u8)
> - RTA_OIF (u32)
> 
> Therefore, rtm_phonet_notify() should use
> 
> NLMSG_ALIGN(sizeof(struct rtmsg)) +
> nla_total_size(1) +
> nla_total_size(4)
> 
> Fixes: f062f41d0657 ("Phonet: routing table Netlink interface")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Remi Denis-Courmont <courmisch@...il.com>

Acked-by: Rémi Denis-Courmont <courmisch@...il.com>

-- 
Rémi Denis-Courmont
http://www.remlab.net/