netdev - Re: [PATCH net-next v3 3/3] selftests/bpf: Add test for the use of new args in cong

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dc051219-5da9-4de9-87fc-82db4c870c3e@linux.dev>
Date: Thu, 2 May 2024 16:39:07 -0700
From: Martin KaFai Lau <martin.lau@...ux.dev>
To: Miao Xu <miaxu@...a.com>
Cc: Eric Dumazet <edumazet@...gle.com>, "David S . Miller"
 <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, David Ahern <dsahern@...nel.org>,
 Martin Lau <kafai@...a.com>, netdev@...r.kernel.org, bpf@...r.kernel.org
Subject: Re: [PATCH net-next v3 3/3] selftests/bpf: Add test for the use of
 new args in cong_control

On 5/1/24 9:23 PM, Miao Xu wrote:
> This patch adds a selftest to show the usage of the new arguments in
> cong_control. For simplicity's sake, the testing example reuses cubic's
> kernel functions.
> ---
> Changes in v3:
> * Renamed the selftest file and the bpf struct_ops' name.
> * Minor changes such as removing unused comments.
> 
> Changes in v2:
> * Added highlights to explain major differences between the bpf program
> and tcp_cubic.c.
> * bpf_tcp_helpers.h should not be further extended, so remove the
>    dependency on this file. Use vmlinux.h instead.
> * Minor changes such as indentation.
> 
> Signed-off-by: Miao Xu <miaxu@...a.com>
> ---
>   .../selftests/bpf/progs/bpf_cc_cubic.c        | 206 ++++++++++++++++++

I just noticed that the bpf_cc_cubic is not run by the test_progs. I have added 
a test to prog_tests/bpf_tcp_ca.c to do that.

I also fixed up your SOB.

Applied. Thanks.

>   .../selftests/bpf/progs/bpf_tracing_net.h     |  10 +
>   2 files changed, 216 insertions(+)
>   create mode 100644 tools/testing/selftests/bpf/progs/bpf_cc_cubic.c