netdev - Re: [PATCH net v2 1/2] ax25: change kfree in ax25_dev_free to ax25_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4ec281f4-f7f8-436c-af0e-c8410ba79139@moroto.mountain>
Date: Fri, 3 May 2024 14:33:20 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Markus Elfring <Markus.Elfring@....de>
Cc: Duoming Zhou <duoming@....edu.cn>, linux-hams@...r.kernel.org,
	netdev@...r.kernel.org, kernel-janitors@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>,
	Jörg Reuter <jreuter@...na.de>,
	Paolo Abeni <pabeni@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Lars Kellogg-Stedman <lars@...bit.com>
Subject: Re: [PATCH net v2 1/2] ax25: change kfree in ax25_dev_free to
 ax25_dev_free

On Fri, May 03, 2024 at 07:36:54AM +0200, Markus Elfring wrote:
> > The ax25_dev is managed by reference counting, so it should not be
> > deallocated directly by kfree() in ax25_dev_free(), replace it with
> > ax25_dev_put() instead.
> 
> You repeated a wording mistake in the summary phrase from a previous cover letter.

Yeah.  That's true.  The subject should be changed to:

Subject: [PATCH] ax25: change kfree() in ax25_dev_free() to ax25_dev_put()

Another option would be:

Subject: [PATCH] ax25: use ax25_dev_put() in ax25_dev_free()

Otherwise the commit message is okay as-is.

regards,
dan carpenter