netdev - Re: [net,PATCH v2] net: ks8851: Queue RX packets in IRQ handler instead of disabling BHs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <86a14471-4bda-471d-ab08-90d4ccd0802d@denx.de>
Date: Fri, 3 May 2024 02:47:23 +0200
From: Marek Vasut <marex@...x.de>
To: Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, Ronald Wahl <ronald.wahl@...itan.com>,
 "David S. Miller" <davem@...emloft.net>, Paolo Abeni <pabeni@...hat.com>,
 Simon Horman <horms@...nel.org>
Subject: Re: [net,PATCH v2] net: ks8851: Queue RX packets in IRQ handler
 instead of disabling BHs

On 5/1/24 4:39 AM, Eric Dumazet wrote:
> On Wed, May 1, 2024 at 4:10 AM Jakub Kicinski <kuba@...nel.org> wrote:
>>
>> On Tue, 30 Apr 2024 21:43:34 +0200 Marek Vasut wrote:
>>> diff --git a/drivers/net/ethernet/micrel/ks8851.h b/drivers/net/ethernet/micrel/ks8851.h
>>> index 31f75b4a67fd7..f311074ea13bc 100644
>>> --- a/drivers/net/ethernet/micrel/ks8851.h
>>> +++ b/drivers/net/ethernet/micrel/ks8851.h
>>> @@ -399,6 +399,7 @@ struct ks8851_net {
>>>
>>>        struct work_struct      rxctrl_work;
>>>
>>> +     struct sk_buff_head     rxq;
>>>        struct sk_buff_head     txq;
>>>        unsigned int            queued_len;
>>
>> One more round, sorry, this structure has a kdoc, please fill in
>> the description for the new member.
> 
> Alternative is to use a local (automatic variable on the stack) struct
> sk_buff_head,
> no need for permanent storage in struct ks8851_net

I think that's even better, done in V3 + addressed feedback from Jakub.