netdev - Re: [PATCH 1/2] driver core: auxiliary bus: show auxiliary device IRQs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202405040108.NWUaSJgz-lkp@intel.com>
Date: Sat, 4 May 2024 01:14:57 +0800
From: kernel test robot <lkp@...el.com>
To: Shay Drory <shayd@...dia.com>, netdev@...r.kernel.org,
	pabeni@...hat.com, davem@...emloft.net, kuba@...nel.org,
	edumazet@...gle.com, gregkh@...uxfoundation.org,
	david.m.ertman@...el.com
Cc: oe-kbuild-all@...ts.linux.dev, rafael@...nel.org, ira.weiny@...el.com,
	linux-rdma@...r.kernel.org, leon@...nel.org, tariqt@...dia.com,
	Shay Drory <shayd@...dia.com>, Parav Pandit <parav@...dia.com>
Subject: Re: [PATCH 1/2] driver core: auxiliary bus: show auxiliary device
 IRQs

Hi Shay,

kernel test robot noticed the following build warnings:

[auto build test WARNING on driver-core/driver-core-testing]
[also build test WARNING on driver-core/driver-core-next driver-core/driver-core-linus net/main net-next/main linus/master v6.9-rc6 next-20240503]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Shay-Drory/driver-core-auxiliary-bus-show-auxiliary-device-IRQs/20240503-123319
base:   driver-core/driver-core-testing
patch link:    https://lore.kernel.org/r/20240503043104.381938-2-shayd%40nvidia.com
patch subject: [PATCH 1/2] driver core: auxiliary bus: show auxiliary device IRQs
config: s390-randconfig-r081-20240503 (https://download.01.org/0day-ci/archive/20240504/202405040108.NWUaSJgz-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240504/202405040108.NWUaSJgz-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405040108.NWUaSJgz-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/base/auxiliary.c:182: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
    * Auxiliary devices can share IRQs. Expose to user whether the provided IRQ is


vim +182 drivers/base/auxiliary.c

   180	
   181	/**
 > 182	 * Auxiliary devices can share IRQs. Expose to user whether the provided IRQ is
   183	 * shared or exclusive.
   184	 */
   185	static ssize_t auxiliary_irq_mode_show(struct device *dev,
   186					       struct device_attribute *attr, char *buf)
   187	{
   188		struct auxiliary_irq_info *info =
   189			container_of(attr, struct auxiliary_irq_info, sysfs_attr);
   190	
   191		if (refcount_read(xa_load(&irqs, info->irq)) > 1)
   192			return sysfs_emit(buf, "%s\n", "shared");
   193		else
   194			return sysfs_emit(buf, "%s\n", "exclusive");
   195	}
   196	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki