netdev - Re: [linux-next:master] BUILD REGRESSION 9c6ecb3cb6e20c4fd7997047213ba0efcf9ada1a

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a0daf2d5-4c72-4d96-a8d4-b15adb7252d5@quicinc.com>
Date: Fri, 3 May 2024 13:23:43 +0530
From: Krishna Kurapati PSSNV <quic_kriskura@...cinc.com>
To: Greg KH <gregkh@...uxfoundation.org>
CC: kernel test robot <lkp@...el.com>,
        Andrew Morton
	<akpm@...ux-foundation.org>,
        Linux Memory Management List
	<linux-mm@...ck.org>,
        <amd-gfx@...ts.freedesktop.org>, <devicetree@...r.kernel.org>,
        <dri-devel@...ts.freedesktop.org>, <intel-gfx@...ts.freedesktop.org>,
        <intel-xe@...ts.freedesktop.org>, <linux-arch@...r.kernel.org>,
        <linux-usb@...r.kernel.org>, <netdev@...r.kernel.org>,
        <nouveau@...ts.freedesktop.org>
Subject: Re: [linux-next:master] BUILD REGRESSION
 9c6ecb3cb6e20c4fd7997047213ba0efcf9ada1a



On 5/3/2024 11:58 AM, Greg KH wrote:
> On Fri, May 03, 2024 at 11:30:50AM +0530, Krishna Kurapati PSSNV wrote:
>>
>>
>> On 5/3/2024 10:42 AM, Greg KH wrote:
>>> Ok, I'm getting tired of seeing these for the USB portion of the tree,
>>> so I went to look for:
>>>
>>> On Fri, May 03, 2024 at 04:44:42AM +0800, kernel test robot wrote:
>>>> |-- arc-randconfig-002-20240503
>>>> |   `-- drivers-usb-dwc3-core.c:warning:variable-hw_mode-set-but-not-used
>>>
>>> This warning (same for all arches), but can't seem to find it anywhere.
>>>
>>> Any hints as to where it would be?
>>>
>>
>> Hi Greg,
>>
>>   I think the hw_mode was not removed in hs_phy_setup and left unused.
>>
>>   Thinh reported the same when there was a merge conflict into linux next
>> (that the hw_mode variable was removed in ss_phy_setup and should be removed
>> in hs_phy_setup as well):
>>
>> https://lore.kernel.org/all/20240426213923.tyeddub4xszypeju@synopsys.com/
>>
>>   Perhaps that was missed ?
> 
> Must have been.  I need it in a format that it can be applied in (a
> 2-way diff can't apply...)
> 

I just checked it with W=1 and it is causing the issue:

/local/mnt/workspace/krishna/linux-next/skales_test/skales/kernel/drivers/usb/dwc3/core.c: 
In function 'dwc3_hs_phy_setup':
/local/mnt/workspace/krishna/linux-next/skales_test/skales/kernel/drivers/usb/dwc3/core.c:679:15: 
warning: variable 'hw_mode' set but not used [-Wunused-but-set-variable]
   unsigned int hw_mode;
                ^

I can send a patch to fix it up. Also, just wanted to confirm if  I skip 
the fixes and CC tags as the main patch wasn't yet merged into any 
stable trees ?

Regards,
Krishna,