netdev - Re: [PATCH net] rtnetlink: Correct nested IFLA_VF_VLAN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m2jzkbfbvg.fsf@gmail.com>
Date: Fri, 03 May 2024 11:06:27 +0100
From: Donald Hunter <donald.hunter@...il.com>
To: Roded Zats <rzats@...oaltonetworks.com>
Cc: davem@...emloft.net,  edumazet@...gle.com,  kuba@...nel.org,
  pabeni@...hat.com,  orcohen@...oaltonetworks.com,  netdev@...r.kernel.org
Subject: Re: [PATCH net] rtnetlink: Correct nested IFLA_VF_VLAN_LIST
 attribute validation

Roded Zats <rzats@...oaltonetworks.com> writes:

> Each attribute inside a nested IFLA_VF_VLAN_LIST is assumed to be a
> struct ifla_vf_vlan_info so the size of such attribute needs to be at least
> of sizeof(struct ifla_vf_vlan_info) which is 14 bytes.
> The current size validation in do_setvfinfo is against NLA_HDRLEN (4 bytes)
> which is less than sizeof(struct ifla_vf_vlan_info) so this validation
> is not enough and a too small attribute might be cast to a
> struct ifla_vf_vlan_info, this might result in an out of bands
> read access when accessing the saved (casted) entry in ivvl.
>
> Fixes: 79aab093a0b5 ("net: Update API for VF vlan protocol 802.1ad support")
> Signed-off-by: Roded Zats <rzats@...oaltonetworks.com>

Reviewed-by: Donald Hunter <donald.hunter@...il.com>