netdev - Re: [RFC PATCH net-next v1 3/3] netdev: add netdev_rx_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240502174913.380dcc38@kernel.org>
Date: Thu, 2 May 2024 17:49:13 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Mina Almasry <almasrymina@...gle.com>
Cc: David Wei <dw@...idwei.uk>, netdev@...r.kernel.org, Michael Chan
 <michael.chan@...adcom.com>, Pavan Chebbi <pavan.chebbi@...adcom.com>, Andy
 Gospodarek <andrew.gospodarek@...adcom.com>, Shailend Chand
 <shailend@...gle.com>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [RFC PATCH net-next v1 3/3] netdev: add
 netdev_rx_queue_restart()

On Thu, 2 May 2024 17:22:41 -0700 Jakub Kicinski wrote:
> On Thu, 2 May 2024 09:46:46 -0700 Mina Almasry wrote:
> > Sorry, I think if we don't need the EXPORT, then I think don't export
> > in the first place. Removing an EXPORT is, AFAIU, tricky. Because if
> > something is exported and then you unexport it could break an out of
> > tree module/driver that developed a dependency on it. Not sure how
> > much of a concern it really is.  
> 
> FWIW don't worry about out of tree code, it's not a concern.

That said (looking at the other thread), if there's no in-tree
user, it's actually incorrect to add an export.