[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240504121154.GF3167983@kernel.org>
Date: Sat, 4 May 2024 13:11:54 +0100
From: Simon Horman <horms@...nel.org>
To: David Wei <dw@...idwei.uk>
Cc: netdev@...r.kernel.org, Michael Chan <michael.chan@...adcom.com>,
Pavan Chebbi <pavan.chebbi@...adcom.com>,
Andy Gospodarek <andrew.gospodarek@...adcom.com>,
Adrian Alvarado <adrian.alvarado@...adcom.com>,
Mina Almasry <almasrymina@...gle.com>,
Shailend Chand <shailend@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [RFC PATCH net-next v2 1/9] queue_api: define queue api
On Wed, May 01, 2024 at 09:54:02PM -0700, David Wei wrote:
> From: Mina Almasry <almasrymina@...gle.com>
>
> This API enables the net stack to reset the queues used for devmem TCP.
>
> Signed-off-by: Mina Almasry <almasrymina@...gle.com>
> Signed-off-by: David Wei <dw@...idwei.uk>
...
> diff --git a/include/net/netdev_queues.h b/include/net/netdev_queues.h
> index 1ec408585373..58042957c39f 100644
> --- a/include/net/netdev_queues.h
> +++ b/include/net/netdev_queues.h
> @@ -60,6 +60,33 @@ struct netdev_stat_ops {
> struct netdev_queue_stats_tx *tx);
> };
>
> +/**
> + * struct netdev_queue_mgmt_ops - netdev ops for queue management
> + *
> + * @ndo_queue_mem_alloc: Allocate memory for an RX queue. The memory returned
> + * in the form of a void* can be passed to
> + * ndo_queue_mem_free() for freeing or to ndo_queue_start
> + * to create an RX queue with this memory.
> + *
> + * @ndo_queue_mem_free: Free memory from an RX queue.
> + *
> + * @ndo_queue_start: Start an RX queue at the specified index.
> + *
> + * @ndo_queue_stop: Stop the RX queue at the specified index.
> + */
> +struct netdev_queue_mgmt_ops {
> + void * (*ndo_queue_mem_alloc)(struct net_device *dev,
> + int idx);
> + void (*ndo_queue_mem_free)(struct net_device *dev,
> + void *queue_mem);
> + int (*ndo_queue_start)(struct net_device *dev,
> + int idx,
> + void *queue_mem);
> + int (*ndo_queue_stop)(struct net_device *dev,
> + int idx,
> + void **out_queue_mem);
Nit: The indentation (before the return types) should use tabs rather than
spaces. And I'm not sure I see the value of the large indentation after
the return types. Basically, I suggest this:
void * (*ndo_queue_mem_alloc)(struct net_device *dev, int idx);
void (*ndo_queue_mem_free)(struct net_device *dev, void *queue_mem);
int (*ndo_queue_start)(struct net_device *dev, int idx,
void *queue_mem);
int (*ndo_queue_stop)(struct net_device *dev, int idx,
void **out_queue_mem);
> +};
> +
> /**
> * DOC: Lockless queue stopping / waking helpers.
> *
> --
> 2.43.0
>
>
Powered by blists - more mailing lists