[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <586a9bc8-aa2a-4312-8936-a10f18e1f9ce@moroto.mountain>
Date: Sat, 4 May 2024 15:18:37 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: oe-kbuild@...ts.linux.dev,
Kamil Horák - 2N <kamilh@...s.com>,
florian.fainelli@...adcom.com,
bcm-kernel-feedback-list@...adcom.com, andrew@...n.ch,
hkallweit1@...il.com
Cc: lkp@...el.com, oe-kbuild-all@...ts.linux.dev, kamilh@...s.com,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/3] net: phy: bcm-phy-lib: Implement BroadR-Reach
link modes
Hi Kamil,
kernel test robot noticed the following build warnings:
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Kamil-Hor-k-2N/net-phy-bcm54811-New-link-mode-for-BroadR-Reach/20240503-164308
base: net/main
patch link: https://lore.kernel.org/r/20240503083719.899312-4-kamilh%40axis.com
patch subject: [PATCH v2 3/3] net: phy: bcm-phy-lib: Implement BroadR-Reach link modes
config: i386-randconfig-141-20240504 (https://download.01.org/0day-ci/archive/20240504/202405041037.sjZak003-lkp@intel.com/config)
compiler: clang version 18.1.4 (https://github.com/llvm/llvm-project e6c3289804a67ea0bb6a86fadbe454dd93b8d855)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
| Closes: https://lore.kernel.org/r/202405041037.sjZak003-lkp@intel.com/
smatch warnings:
drivers/net/phy/broadcom.c:627 bcm5481x_config_delay_swap() error: uninitialized symbol 'ret'.
drivers/net/phy/broadcom.c:1249 bcm_read_master_slave() error: uninitialized symbol 'cfg'.
vim +/ret +627 drivers/net/phy/broadcom.c
f1e9c8e593d6ea Kamil Horák - 2N 2024-05-03 611 static int bcm5481x_config_delay_swap(struct phy_device *phydev)
57bb7e222804c6 Anton Vorontsov 2008-03-04 612 {
b14995ac2527b4 Jon Mason 2016-11-04 613 struct device_node *np = phydev->mdio.dev.of_node;
57bb7e222804c6 Anton Vorontsov 2008-03-04 614 int ret;
57bb7e222804c6 Anton Vorontsov 2008-03-04 615
f1e9c8e593d6ea Kamil Horák - 2N 2024-05-03 616 /* Set up the delay. */
042cb56478152b Tao Ren 2018-11-05 617 bcm54xx_config_clock_delay(phydev);
57bb7e222804c6 Anton Vorontsov 2008-03-04 618
b14995ac2527b4 Jon Mason 2016-11-04 619 if (of_property_read_bool(np, "enet-phy-lane-swap")) {
b14995ac2527b4 Jon Mason 2016-11-04 620 /* Lane Swap - Undocumented register...magic! */
b14995ac2527b4 Jon Mason 2016-11-04 621 ret = bcm_phy_write_exp(phydev, MII_BCM54XX_EXP_SEL_ER + 0x9,
b14995ac2527b4 Jon Mason 2016-11-04 622 0x11B);
b14995ac2527b4 Jon Mason 2016-11-04 623 if (ret < 0)
b14995ac2527b4 Jon Mason 2016-11-04 624 return ret;
b14995ac2527b4 Jon Mason 2016-11-04 625 }
"ret" not initialized on else path.
b14995ac2527b4 Jon Mason 2016-11-04 626
57bb7e222804c6 Anton Vorontsov 2008-03-04 @627 return ret;
Also "return 0;" is always better.
57bb7e222804c6 Anton Vorontsov 2008-03-04 628 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists