netdev - Re: [PATCH 0/5] pull request (net-next): ipsec-next 2024-05-03

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240504143657.GA2279@kernel.org>
Date: Sat, 4 May 2024 15:36:57 +0100
From: Simon Horman <horms@...nel.org>
To: Steffen Klassert <steffen.klassert@...unet.com>
Cc: David Miller <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
	Herbert Xu <herbert@...dor.apana.org.au>, netdev@...r.kernel.org
Subject: Re: [PATCH 0/5] pull request (net-next): ipsec-next 2024-05-03

On Fri, May 03, 2024 at 10:27:26AM +0200, Steffen Klassert wrote:
> 1) Remove Obsolete UDP_ENCAP_ESPINUDP_NON_IKE Support.
>    This was defined by an early version of an IETF draft
>    that did not make it to a standard.
> 
> 2) Introduce direction attribute for xfrm states.
>    xfrm states have a direction, a stsate can be used
>    either for input or output packet processing.
>    Add a direction to xfrm states to make it clear
>    for what a xfrm state is used.
> 
> All patches from Antony Antony.
> 
> Please pull or let me know if there are problems.

Hi Steffen, all,

This comment is not strictly related to this pull request
and certainly not intended to impede progress of it towards upstream.

However, while looking over it I noticed that Sparse flags a rather
large number of warnings in xfrm code, mostly relating to __rcu annotations.
I'm wondering if, at some point, these could be addressed somehow.