| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20240506094855.12944-1-aleksander.lobakin@intel.com>
Date: Mon, 6 May 2024 11:48:48 +0200
From: Alexander Lobakin <aleksander.lobakin@...el.com>
To: "David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>
Cc: Alexander Lobakin <aleksander.lobakin@...el.com>,
Christoph Hellwig <hch@....de>,
Marek Szyprowski <m.szyprowski@...sung.com>,
Robin Murphy <robin.murphy@....com>,
Joerg Roedel <joro@...tes.org>,
Will Deacon <will@...nel.org>,
"Rafael J. Wysocki" <rafael@...nel.org>,
Magnus Karlsson <magnus.karlsson@...el.com>,
nex.sw.ncis.osdt.itp.upstreaming@...el.com,
bpf@...r.kernel.org,
netdev@...r.kernel.org,
iommu@...ts.linux.dev,
linux-kernel@...r.kernel.org
Subject: [PATCH net-next v5 0/7] dma: skip calling no-op sync ops when possible
The series grew from Eric's idea and patch at [0]. The idea of using the
shortcut for direct DMA as well belongs to Chris.
When an architecture doesn't need DMA synchronization and the buffer is
not an SWIOTLB buffer, most of times the kernel and the drivers end up
calling DMA sync operations for nothing.
Even when DMA is direct, this involves a good non-inline call ladder and
eats a bunch of CPU time. With IOMMU, this results in calling indirect
calls on hotpath just to check what is already known and return.
XSk is been using a custom shortcut for that for quite some time.
I recently wanted to introduce a similar one for Page Pool. Let's combine
all this into one generic shortcut, which would cover all DMA sync ops
and all types of DMA (direct, IOMMU, ...).
* #1 adds stub inlines to be able to compile DMA sync ops out when not
needed.
* #2 adds generic shortcut and enables it for direct DMA.
* #3 adds ability to skip DMA syncs behind an IOMMU.
* #4-5 are just cleanups for Page Pool to avoid merge conflicts in future.
* #6 checks for the shortcut as early as possible in the Page Pool code to
make sure no cycles wasted.
* #7 replaces XSk's shortcut with the generic one.
On 100G NIC, the result is +3-5% for direct DMA and +10-11% for IOMMU.
As a bonus, XSk core now allows batched buffer allocations for IOMMU
setups.
If the shortcut is not available on some system, there should be no
visible performance regressions.
[0] https://lore.kernel.org/netdev/20221115182841.2640176-1-edumazet@google.com
Alexander Lobakin (7):
dma: compile-out DMA sync op calls when not used
dma: avoid redundant calls for sync operations
iommu/dma: avoid expensive indirect calls for sync operations
page_pool: make sure frag API fields don't span between cachelines
page_pool: don't use driver-set flags field directly
page_pool: check for DMA sync shortcut earlier
xsk: use generic DMA sync shortcut instead of a custom one
kernel/dma/Kconfig | 5 +
include/net/page_pool/types.h | 25 ++++-
include/linux/device.h | 4 +
include/linux/dma-map-ops.h | 12 ++
include/linux/dma-mapping.h | 105 +++++++++++++-----
include/net/xdp_sock_drv.h | 7 +-
include/net/xsk_buff_pool.h | 14 +--
drivers/iommu/dma-iommu.c | 3 +-
drivers/net/ethernet/engleder/tsnep_main.c | 2 +-
.../net/ethernet/freescale/dpaa2/dpaa2-xsk.c | 2 +-
drivers/net/ethernet/intel/i40e/i40e_xsk.c | 2 +-
drivers/net/ethernet/intel/ice/ice_xsk.c | 2 +-
drivers/net/ethernet/intel/igc/igc_main.c | 2 +-
drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c | 2 +-
.../ethernet/mellanox/mlx5/core/en/xsk/rx.c | 4 +-
.../net/ethernet/mellanox/mlx5/core/en_rx.c | 2 +-
drivers/net/ethernet/netronome/nfp/nfd3/xsk.c | 2 +-
.../net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +-
kernel/dma/mapping.c | 69 +++++++++---
kernel/dma/swiotlb.c | 6 +
net/core/page_pool.c | 78 ++++++++-----
net/xdp/xsk_buff_pool.c | 28 +----
22 files changed, 245 insertions(+), 133 deletions(-)
---
>From v4[1]:
* #6:
* rebase on top of the latest net-next;
* fix Page Pool compilation errors when !DMA_NEED_SYNC.
>From v3[2]:
* #1:
* don't prefix DMA sync ops with '__', just define them as empty inlines
when !DMA_NEED_SYNC (Chris, Robin);
* always select DMA_NEED_SYNC when DMA_API_DEBUG (^);
* #2:
* don't use BIT(), keep the style consistent (^);
* check for dma_map_ops::sync_sg_*() in dma_setup_need_sync() (^);
* don't reset the flag in swiotlb_alloc() as it's not streaming API (^);
* instead of 'dma_skip_sync', name the flag 'dma_need_sync' and inverse
the logic (^);
* setup the shortcut in dma_set_mask() (assuming every driver using DMA
must call it on probe) (^);
* combine dma_direct() and (ops->flags & CAN_SKIP_SYNC) checks (Robin);
* #3:
- pick Acked-by (Robin).
>From v2[3]:
* #1:
* use two tabs for indenting multi-line function prototypes (Chris);
* #2:
* make shortcut clearing function generic and move it out of the
SWIOTLB code (Chris);
* remove dma_set_skip_sync(): use direct assignment during the initial
setup, not used anywhere else (Chris);
* commitmsg: remove "NIC" and the workaround paragraph (Chris).
>From v1[4]:
* #1:
* use static inlines instead of macros (Chris);
* move CONFIG_DMA_NEED_SYNC check into dma_skip_sync() (Robin);
* #2:
* use a new dma_map_ops flag instead of new callback, assume the same
conditions as for direct DMA are enough (Petr, Robin);
* add more code comments to make sure the whole idea and path are
clear (Petr, Robin, Chris);
* #2, #3: correct the Git tags and the authorship a bit.
Not addressed in v2:
* #1:
* dma_sync_*range_*() are still wrapped, as some subsystems may want
to call the underscored versions directly (e.g. Page Pool);
* #2:
* the new dev->dma_skip_sync bit is still preferred over checking for
READ_ONCE(dev->dma_uses_io_tlb) + dev_is_dma_coherent() on hotpath
as a faster solution.
[1] https://lore.kernel.org/netdev/20240423135832.2271696-1-aleksander.lobakin@intel.com
[2] https://lore.kernel.org/netdev/20240214162201.4168778-1-aleksander.lobakin@intel.com
[3] https://lore.kernel.org/netdev/20240205110426.764393-1-aleksander.lobakin@intel.com
[4] https://lore.kernel.org/netdev/20240126135456.704351-1-aleksander.lobakin@intel.com
--
2.45.0
Powered by blists - more mailing lists