netdev - Re: [RFC PATCH net-next v2 1/9] queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4f8df603-7385-4771-ab78-24e701eabee3@davidwei.uk>
Date: Sun, 5 May 2024 17:34:18 -0700
From: David Wei <dw@...idwei.uk>
To: Simon Horman <horms@...nel.org>
Cc: netdev@...r.kernel.org, Michael Chan <michael.chan@...adcom.com>,
 Pavan Chebbi <pavan.chebbi@...adcom.com>,
 Andy Gospodarek <andrew.gospodarek@...adcom.com>,
 Adrian Alvarado <adrian.alvarado@...adcom.com>,
 Mina Almasry <almasrymina@...gle.com>, Shailend Chand <shailend@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [RFC PATCH net-next v2 1/9] queue_api: define queue api

On 2024-05-04 05:11, Simon Horman wrote:
> On Wed, May 01, 2024 at 09:54:02PM -0700, David Wei wrote:
>> From: Mina Almasry <almasrymina@...gle.com>

...

>> +struct netdev_queue_mgmt_ops {
>> +       void *                  (*ndo_queue_mem_alloc)(struct net_device *dev,
>> +                                                      int idx);
>> +       void                    (*ndo_queue_mem_free)(struct net_device *dev,
>> +                                                     void *queue_mem);
>> +       int                     (*ndo_queue_start)(struct net_device *dev,
>> +                                                  int idx,
>> +                                                  void *queue_mem);
>> +       int                     (*ndo_queue_stop)(struct net_device *dev,
>> +                                                 int idx,
>> +                                                 void **out_queue_mem);
> 
> Nit: The indentation (before the return types) should use tabs rather than
>      spaces. And I'm not sure I see the value of the large indentation after
>      the return types. Basically, I suggest this:
> 
> 	void * (*ndo_queue_mem_alloc)(struct net_device *dev, int idx);
> 	void   (*ndo_queue_mem_free)(struct net_device *dev, void *queue_mem);
> 	int    (*ndo_queue_start)(struct net_device *dev, int idx,
> 				  void *queue_mem);
> 	int    (*ndo_queue_stop)(struct net_device *dev, int idx,
> 				 void **out_queue_mem);
> 

Hi Simon, this patch came from Shailend and Mina which I applied to this
patchset. We'll make sure it's formatted properly once we send a
non-RFC. Thanks.

>> +};
>> +
>>  /**
>>   * DOC: Lockless queue stopping / waking helpers.
>>   *
>> -- 
>> 2.43.0
>>
>>