netdev - Re: [PATCH net-next] mptcp: fix possible NULL dereferences

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48d71ee4-7b01-48a8-a2ec-9030204eac07@kernel.org>
Date: Mon, 6 May 2024 17:04:34 +0200
From: Matthieu Baerts <matttbe@...nel.org>
To: Eric Dumazet <edumazet@...gle.com>, "David S . Miller"
 <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org, eric.dumazet@...il.com,
 syzbot <syzkaller@...glegroups.com>, Jason Xing <kernelxing@...cent.com>,
 MPTCP Upstream <mptcp@...ts.linux.dev>
Subject: Re: [PATCH net-next] mptcp: fix possible NULL dereferences

Hi Eric,

(+cc MPTCP ML for the CI, patch tracking, and other devs)

On 06/05/2024 14:30, Eric Dumazet wrote:
> subflow_add_reset_reason(skb, ...) can fail.
> 
> We can not assume mptcp_get_ext(skb) always return a non NULL pointer.

Good catch! Thank you for the fix!

It looks good to me:

Reviewed-by: Matthieu Baerts (NGI0) <matttbe@...nel.org>

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.