[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240506153307.114104-1-dawid.osuchowski@linux.intel.com>
Date: Mon, 6 May 2024 17:33:07 +0200
From: Dawid Osuchowski <dawid.osuchowski@...ux.intel.com>
To: intel-wired-lan@...ts.osuosl.org
Cc: netdev@...r.kernel.org,
Ngai-Mint Kwan <ngai-mint.kwan@...el.com>,
Mateusz Polchlopek <mateusz.polchlopek@...el.com>,
Pawel Chmielewski <pawel.chmielewski@...el.com>,
Simon Horman <horms@...nel.org>,
Dawid Osuchowski <dawid.osuchowski@...ux.intel.com>
Subject: [PATCH iwl-net v4] ice: Do not get coalesce settings while in reset
From: Ngai-Mint Kwan <ngai-mint.kwan@...el.com>
Getting coalesce settings while reset is in progress can cause NULL
pointer deference bug.
If under reset, abort get coalesce for ethtool.
Fixes: 67fe64d78c43 ("ice: Implement getting and setting ethtool coalesce")
Signed-off-by: Ngai-Mint Kwan <ngai-mint.kwan@...el.com>
Reviewed-by: Mateusz Polchlopek <mateusz.polchlopek@...el.com>
Signed-off-by: Pawel Chmielewski <pawel.chmielewski@...el.com>
Reviewed-by: Simon Horman <horms@...nel.org>
Co-developed-by: Dawid Osuchowski <dawid.osuchowski@...ux.intel.com>
Signed-off-by: Dawid Osuchowski <dawid.osuchowski@...ux.intel.com>
---
Changes since v1:
* Added "Fixes:" tag
Changes since v2:
* Rebased over current IWL net branch
* Confirmed that the issue previously reported for this patch [1] by
Himasekhar Reddy Pucha was caused by other, internally tracked issue
Changes since v3:
* Using ice_wait_for_reset() instead of returning -EBUSY
[1] https://lore.kernel.org/netdev/BL0PR11MB3122D70ABDE6C2ACEE376073BD90A@BL0PR11MB3122.namprd11.prod.outlook.com/
---
drivers/net/ethernet/intel/ice/ice_ethtool.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.c b/drivers/net/ethernet/intel/ice/ice_ethtool.c
index d91f41f61bce..4ff16fd2eb94 100644
--- a/drivers/net/ethernet/intel/ice/ice_ethtool.c
+++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c
@@ -3815,6 +3815,13 @@ __ice_get_coalesce(struct net_device *netdev, struct ethtool_coalesce *ec,
struct ice_netdev_priv *np = netdev_priv(netdev);
struct ice_vsi *vsi = np->vsi;
+ if (ice_is_reset_in_progress(vsi->back->state)) {
+ int err = ice_wait_for_reset(vsi->back, 10 * HZ);
+
+ if (err)
+ return err;
+ }
+
if (q_num < 0)
q_num = 0;
--
2.44.0
Powered by blists - more mailing lists