netdev - Re: [RFC PATCH net-next v2 3/9] netdev: add netdev_rx_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b1d37565-578b-455d-a73f-387d713a2893@davidwei.uk>
Date: Sun, 5 May 2024 17:41:14 -0700
From: David Wei <dw@...idwei.uk>
To: Simon Horman <horms@...nel.org>
Cc: netdev@...r.kernel.org, Michael Chan <michael.chan@...adcom.com>,
 Pavan Chebbi <pavan.chebbi@...adcom.com>,
 Andy Gospodarek <andrew.gospodarek@...adcom.com>,
 Adrian Alvarado <adrian.alvarado@...adcom.com>,
 Mina Almasry <almasrymina@...gle.com>, Shailend Chand <shailend@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [RFC PATCH net-next v2 3/9] netdev: add netdev_rx_queue_restart()

On 2024-05-04 05:20, Simon Horman wrote:
> On Wed, May 01, 2024 at 09:54:04PM -0700, David Wei wrote:
>> From: Mina Almasry <almasrymina@...gle.com>
>>
>> Add netdev_rx_queue_restart() function to netdev_rx_queue.h. This is
>> taken from Mina's work in [1] with a slight modification of taking
>> rtnl_lock() during the queue stop and start ops.
>>
>> For bnxt specifically, if the firmware doesn't support
>> BNXT_RST_RING_SP_EVENT, then ndo_queue_stop() returns -EOPNOTSUPP and
>> the whole restart fails. Unlike bnxt_rx_ring_reset(), there is no
>> attempt to reset the whole device.
>>
>> [1]: https://lore.kernel.org/linux-kernel/20240403002053.2376017-6-almasrymina@google.com/#t
>>
>> Signed-off-by: David Wei <dw@...idwei.uk>
> 
> nit: Mina's From line is above, but there is no corresponding Signed-off-by
>      line here.

This patch isn't a clean cherry pick, I pulled the core logic of
netdev_rx_queue_restart() from the middle of another patch. In these
cases should I be manually adding Signed-off-by tag?

...

>> diff --git a/net/core/netdev_rx_queue.c b/net/core/netdev_rx_queue.c
>> new file mode 100644
>> index 000000000000..9633fb36f6d1
>> --- /dev/null
>> +++ b/net/core/netdev_rx_queue.c
>> @@ -0,0 +1,58 @@
>> +/* SPDX-License-Identifier: GPL-2.0 */
> 
> nit: my understanding is that, as a .c file, the correct SPDX format is:
> 
> // SPDX-License-Identifier: GPL-2.0

Thanks, I will fix this.

> 
> ...