netdev - Re: [PATCH net-next v12 15/15] net: stmmac: dwmac-loongson: Add loongson module author

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <774mi7wcv5nsz2al2qgdcgbdlh37io45qtorzyvrrydinjyp4v@kectrx234tgk>
Date: Mon, 6 May 2024 07:44:32 +0300
From: Serge Semin <fancer.lancer@...il.com>
To: Huacai Chen <chenhuacai@...nel.org>
Cc: Yanteng Si <siyanteng@...ngson.cn>, andrew@...n.ch, 
	hkallweit1@...il.com, peppe.cavallaro@...com, alexandre.torgue@...s.st.com, 
	joabreu@...opsys.com, Jose.Abreu@...opsys.com, linux@...linux.org.uk, 
	guyinggang@...ngson.cn, netdev@...r.kernel.org, chris.chenfeiyang@...il.com, 
	siyanteng01@...il.com
Subject: Re: [PATCH net-next v12 15/15] net: stmmac: dwmac-loongson: Add
 loongson module author

On Mon, May 06, 2024 at 10:12:14AM +0800, Huacai Chen wrote:
> Hi, Yanteng,
> 
> On Thu, Apr 25, 2024 at 9:11 PM Yanteng Si <siyanteng@...ngson.cn> wrote:
> >
> > Add Yanteng Si as MODULE_AUTHOR of  Loongson DWMAC PCI driver.
> >
> > Signed-off-by: Feiyang Chen <chenfeiyang@...ngson.cn>
> > Signed-off-by: Yinggang Gu <guyinggang@...ngson.cn>
> > Signed-off-by: Yanteng Si <siyanteng@...ngson.cn>
> > ---
> >  drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
> > index dea02de030e6..f0eebed751f3 100644
> > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
> > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
> > @@ -638,4 +638,5 @@ module_pci_driver(loongson_dwmac_driver);
> >
> >  MODULE_DESCRIPTION("Loongson DWMAC PCI driver");
> >  MODULE_AUTHOR("Qing Zhang <zhangqing@...ngson.cn>");
> > +MODULE_AUTHOR("Yanteng Si <siyanteng@...ngson.cn>");
> >  MODULE_LICENSE("GPL v2");

> The patch splitting is toooo strange for this line.

It's not.

> Since Qing Zhang
> is the major author of GMAC, and you are the major author of GNET, I
> think this line can be in Patch-13.

The patch size isn't something that determines the change placement,
but the change solving only one problem per patch. This patch is about
adding the driver author. The patch 13 is about adding the GNET device
support. It's perfectly fine to have these changes provided separately
and in the order they are submitted in v12. Besides the patch 13 has
just started getting to look reviewable enough. Stop trying to mix up
various changes in there again.

It was me who asked Yanteng to detach this changes into a separate and
final patch of the series, for the exact reasons I described above.

-Serge(y)

> 
> Huacai
> 
> > --
> > 2.31.4
> >