netdev - Re: [PATCH net] selftests: test_bridge_neigh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZjiP_3XiXJ0CoChQ@shredder>
Date: Mon, 6 May 2024 11:08:31 +0300
From: Ido Schimmel <idosch@...dia.com>
To: netdev@...r.kernel.org
Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
	edumazet@...gle.com, razor@...ckwall.org
Subject: Re: [PATCH net] selftests: test_bridge_neigh_suppress.sh: Try to
 stabilize test

On Sun, May 05, 2024 at 05:54:12PM +0300, Ido Schimmel wrote:
> The arping and ndisc6 test cases sometimes pass on non-debug kernels
> [1], but fail on debug kernels [2] even when it is the same branch that
> is being tested in the netdev CI.
> 
> These are the only test cases that are unstable and the only ones that
> use a timeout. Therefore, my only theory is that the timeout is too
> short although it is currently set to 5 seconds.
> 
> Try to stabilize these test cases by using a timeout of 20 seconds.
> 
> [1]
>  # Per-port ARP suppression - VLAN 10
>  # ----------------------------------
>  # TEST: arping                                                        [ OK ]
>  # TEST: ARP suppression                                               [ OK ]
>  # TEST: "neigh_suppress" is on                                        [ OK ]
>  # TEST: arping                                                        [ OK ]
>  # TEST: ARP suppression                                               [ OK ]
> 
> [2]
>  # Per-port ARP suppression - VLAN 10
>  # ----------------------------------
>  # TEST: arping                                                        [FAIL]
>  # TEST: ARP suppression                                               [ OK ]
>  # TEST: "neigh_suppress" is on                                        [ OK ]
>  # TEST: arping                                                        [FAIL]
>  # TEST: ARP suppression                                               [ OK ]
> 
> Reported-by: Jakub Kicinski <kuba@...nel.org>
> Closes: https://lore.kernel.org/netdev/20240426074015.251854d4@kernel.org/
> Fixes: 7648ac72dcd7 ("selftests: net: Add bridge neighbor suppression test")
> Signed-off-by: Ido Schimmel <idosch@...dia.com>
> ---
> I'm unable to reproduce these failures locally. Tried with both regular
> and debug configs. Let's wait for the CI results and see if this patch
> helps.
> ---

Checked the results. Looks like it didn't help. Don't have other ideas
at the moment.

pw-bot: changes-requested