netdev - Re: [PATCH v2] selftests/net: fix uninitialized variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <610f9818-b899-1f70-8110-f88db47595ff@kernel.org>
Date: Mon, 6 May 2024 18:27:07 -0700 (PDT)
From: Mat Martineau <martineau@...nel.org>
To: John Hubbard <jhubbard@...dia.com>
cc: Shuah Khan <shuah@...nel.org>, "David S . Miller" <davem@...emloft.net>, 
    Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, 
    Paolo Abeni <pabeni@...hat.com>, 
    Steffen Klassert <steffen.klassert@...unet.com>, 
    Herbert Xu <herbert@...dor.apana.org.au>, 
    Andreas Färber <afaerber@...e.de>, 
    Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>, 
    Matthieu Baerts <matttbe@...nel.org>, Geliang Tang <geliang@...nel.org>, 
    Pravin B Shelar <pshelar@....org>, 
    Willem de Bruijn <willemdebruijn.kernel@...il.com>, 
    Alexander Mikhalitsyn <alexander@...alicyn.com>, 
    zhujun2 <zhujun2@...s.chinamobile.com>, Petr Machata <petrm@...dia.com>, 
    Ido Schimmel <idosch@...dia.com>, Hangbin Liu <liuhangbin@...il.com>, 
    Nikolay Aleksandrov <razor@...ckwall.org>, 
    Benjamin Poirier <bpoirier@...dia.com>, 
    Sebastian Andrzej Siewior <bigeasy@...utronix.de>, 
    Dmitry Safonov <0x7f454c46@...il.com>, netdev@...r.kernel.org, 
    linux-arm-kernel@...ts.infradead.org, linux-actions@...ts.infradead.org, 
    mptcp@...ts.linux.dev, dev@...nvswitch.org, 
    Valentin Obst <kernel@...entinobst.de>, linux-kselftest@...r.kernel.org, 
    LKML <linux-kernel@...r.kernel.org>, llvm@...ts.linux.dev
Subject: Re: [PATCH v2] selftests/net: fix uninitialized variables

On Mon, 6 May 2024, John Hubbard wrote:

> When building with clang, via:
>
>    make LLVM=1 -C tools/testing/selftest
>
> ...clang warns about three variables that are not initialized in all
> cases:
>
> 1) The opt_ipproto_off variable is used uninitialized if "testname" is
> not "ip". Willem de Bruijn pointed out that this is an actual bug, and
> suggested the fix that I'm using here (thanks!).
>
> 2) The addr_len is used uninitialized, but only in the assert case,
>   which bails out, so this is harmless.
>
> 3) The family variable in add_listener() is only used uninitialized in
>   the error case (neither IPv4 nor IPv6 is specified), so it's also
>   harmless.
>
> Fix by initializing each variable.
>
> Cc: Willem de Bruijn <willemdebruijn.kernel@...il.com>
> Signed-off-by: John Hubbard <jhubbard@...dia.com>

Hi John -

MPTCP change looks good to me:

Acked-by: Mat Martineau <martineau@...nel.org>