netdev - Re: [PATCH net-next v2 2/2] net: phy: marvell: add support for MV88E6250 family internal PHYs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a46c1c48-653b-48b1-9a56-da2030545f81@lunn.ch>
Date: Tue, 7 May 2024 14:18:11 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Matthias Schiffer <matthias.schiffer@...tq-group.com>
Cc: Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux@...tq-group.com
Subject: Re: [PATCH net-next v2 2/2] net: phy: marvell: add support for
 MV88E6250 family internal PHYs

On Thu, May 02, 2024 at 01:13:01PM +0200, Matthias Schiffer wrote:
> The embedded PHYs of the 88E6250 family switches are very basic - they
> do not even have an Extended Address / Page register.
> 
> This adds support for the PHYs to the driver to set up PHY interrupts
> and retrieve error stats. To deal with PHYs without a page register,
> "simple" variants of all stat handling functions are introduced.
> 
> The code should work with all 88E6250 family switches (6250/6220/6071/
> 6070/6020). The PHY ID 0x01410db0 was read from a 88E6020, under the
> assumption that all switches of this family use the same ID. The spec
> only lists the prefix 0x01410c00 and leaves the last 10 bits as reserved,
> but that seems too unspecific to be useful, as it would cover several
> existing PHY IDs already supported by the driver; therefore, the ID read
> from the actual hardware is used.
> 
> Signed-off-by: Matthias Schiffer <matthias.schiffer@...tq-group.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew