netdev - Re: [PATCH net-next] net: dst_cache: annotate data-races around dst_cache->reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <72846f668d23ff90fdbddff1d4408e41742c66a3.camel@redhat.com>
Date: Tue, 07 May 2024 16:17:44 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Eric Dumazet <edumazet@...gle.com>, "David S . Miller"
 <davem@...emloft.net>,  Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH net-next] net: dst_cache: annotate data-races around
 dst_cache->reset_ts

On Tue, 2024-05-07 at 13:20 +0000, Eric Dumazet wrote:
> dst_cache->reset_ts is read or written locklessly,
> add READ_ONCE() and WRITE_ONCE() annotations.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

I was wondering if we need the annotation when the RD/WR ops all happen
on the same CPU, but dst_cache_reset() can happen on a different core,
so LGTM, thanks!

Acked-by: Paolo Abeni <pabeni@...hat.com>