netdev - Re: [PATCH net v2 2/2] net: ethernet: mediatek: use ADMAv1 instead of ADMAv2.0 on MT7981 and MT7986

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9b9a42af-1a73-4896-9bfe-afd55ae5b278@intel.com>
Date: Tue, 7 May 2024 17:54:46 +0200
From: Przemek Kitszel <przemyslaw.kitszel@...el.com>
To: Daniel Golle <daniel@...rotopia.org>, Felix Fietkau <nbd@....name>, "Sean
 Wang" <sean.wang@...iatek.com>, Mark Lee <Mark-MC.Lee@...iatek.com>, "Lorenzo
 Bianconi" <lorenzo@...nel.org>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, "Paolo
 Abeni" <pabeni@...hat.com>, Matthias Brugger <matthias.bgg@...il.com>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>, <linux-mediatek@...ts.infradead.org>
Subject: Re: [PATCH net v2 2/2] net: ethernet: mediatek: use ADMAv1 instead of
 ADMAv2.0 on MT7981 and MT7986

On 5/7/24 14:25, Daniel Golle wrote:
> ADMAv2.0 is plagued by RX hangs which can't easily detected and happen upon

nit: missing "be" after "can't",
but no need to respin just for that

> receival of a corrupted Ethernet frame.
> 
> Use ADMAv1 instead which is also still present and usable, and doesn't
> suffer from that problem.
> 
> Fixes: 197c9e9b17b1 ("net: ethernet: mtk_eth_soc: introduce support for mt7986 chipset")
> Co-developed-by: Lorenzo Bianconi <lorenzo@...nel.org>
> Signed-off-by: Lorenzo Bianconi <lorenzo@...nel.org>
> Signed-off-by: Daniel Golle <daniel@...rotopia.org>
> ---
> v2: improve commit message
>   drivers/net/ethernet/mediatek/mtk_eth_soc.c | 46 ++++++++++-----------
>   1 file changed, 23 insertions(+), 23 deletions(-)
> 
> diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> index 3eefb735ce19..d7d73295f0dc 100644
> --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> @@ -110,16 +110,16 @@ static const struct mtk_reg_map mt7986_reg_map = {

MT7981 uses the same regmap, so is covered too, fine

>   	.tx_irq_mask		= 0x461c,
>   	.tx_irq_status		= 0x4618,
>   	.pdma = {
> -		.rx_ptr		= 0x6100,
> -		.rx_cnt_cfg	= 0x6104,
> -		.pcrx_ptr	= 0x6108,
> -		.glo_cfg	= 0x6204,
> -		.rst_idx	= 0x6208,
> -		.delay_irq	= 0x620c,
> -		.irq_status	= 0x6220,
> -		.irq_mask	= 0x6228,
> -		.adma_rx_dbg0	= 0x6238,
> -		.int_grp	= 0x6250,
> +		.rx_ptr		= 0x4100,
> +		.rx_cnt_cfg	= 0x4104,
> +		.pcrx_ptr	= 0x4108,
> +		.glo_cfg	= 0x4204,
> +		.rst_idx	= 0x4208,
> +		.delay_irq	= 0x420c,
> +		.irq_status	= 0x4220,
> +		.irq_mask	= 0x4228,
> +		.adma_rx_dbg0	= 0x4238,
> +		.int_grp	= 0x4250,
>   	},
>   	.qdma = {
>   		.qtx_cfg	= 0x4400,

// ...

Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>