netdev - Re: [PATCH net-next v1 1/1] can: mcp251x: Fix up includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZjpXWVVG105w_lSg@smile.fi.intel.com>
Date: Tue, 7 May 2024 19:31:21 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: linux-can@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Cc: Marc Kleine-Budde <mkl@...gutronix.de>,
	Vincent Mailhol <mailhol.vincent@...adoo.fr>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net-next v1 1/1] can: mcp251x: Fix up includes

On Fri, Apr 12, 2024 at 08:33:32PM +0300, Andy Shevchenko wrote:
> This driver is including the legacy GPIO header <linux/gpio.h>
> but the only thing it is using from that header is the wrong
> define for GPIOF_DIR_OUT.
> 
> Fix it up by using GPIO_LINE_DIRECTION_* macros respectively.

Marc, any comments on this?

-- 
With Best Regards,
Andy Shevchenko