netdev - Re: [PATCH net-next 0/2] gve: Minor cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zjpf8TqVqt8aCsOp@lzaremba-mobl.ger.corp.intel.com>
Date: Tue, 7 May 2024 19:08:01 +0200
From: Larysa Zaremba <larysa.zaremba@...el.com>
To: Simon Horman <horms@...nel.org>
CC: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
	<edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, Jeroen de Borst <jeroendb@...gle.com>, "Praveen
 Kaligineedi" <pkaligineedi@...gle.com>, Shailend Chand <shailend@...gle.com>,
	Nathan Chancellor <nathan@...nel.org>, Nick Desaulniers
	<ndesaulniers@...gle.com>, Bill Wendling <morbo@...gle.com>, Justin Stitt
	<justinstitt@...gle.com>, Dan Carpenter <dan.carpenter@...aro.org>, Kees Cook
	<keescook@...omium.org>, <netdev@...r.kernel.org>, <llvm@...ts.linux.dev>,
	<linux-hardening@...r.kernel.org>
Subject: Re: [PATCH net-next 0/2] gve: Minor cleanups

On Fri, May 03, 2024 at 09:31:25PM +0100, Simon Horman wrote:
> Hi,
> 
> This short patchset provides two minor cleanups for the gve driver.
> 
> These were found by tooling as mentioned in each patch,
> and otherwise by inspection.
> 
> No change in run time behaviour is intended.
> Each patch is compile tested only.
>

Both patches look fine to me.

Reviewed-by: Larysa Zaremba <larysa.zaremba@...el.com>
 
> ---
> Simon Horman (2):
>       gve: Avoid unnecessary use of comma operator
>       gve: Use ethtool_sprintf/puts() to fill stats strings
> 
>  drivers/net/ethernet/google/gve/gve_adminq.c  |  4 +--
>  drivers/net/ethernet/google/gve/gve_ethtool.c | 42 +++++++++++----------------
>  2 files changed, 19 insertions(+), 27 deletions(-)
> 
> base-commit: 5829614a7b3b2cc9820efb2d29a205c00d748fcf
> 
>