netdev - Re: [PATCH 1/1] [RFC] ethernet: Convert from tasklet to BH workqueue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zjp/kgBE2ddjV044@shell.armlinux.org.uk>
Date: Tue, 7 May 2024 20:22:58 +0100
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: Allen Pais <apais@...ux.microsoft.com>
Cc: netdev@...r.kernel.org, jes@...ined-monkey.org, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	kda@...ux-powerpc.org, cai.huoqing@...ux.dev,
	dougmill@...ux.ibm.com, npiggin@...il.com,
	christophe.leroy@...roup.eu, aneesh.kumar@...nel.org,
	naveen.n.rao@...ux.ibm.com, nnac123@...ux.ibm.com,
	tlfalcon@...ux.ibm.com, cooldavid@...ldavid.org,
	marcin.s.wojtas@...il.com, mlindner@...vell.com,
	stephen@...workplumber.org, nbd@....name, sean.wang@...iatek.com,
	Mark-MC.Lee@...iatek.com, lorenzo@...nel.org,
	matthias.bgg@...il.com, angelogioacchino.delregno@...labora.com,
	borisp@...dia.com, bryan.whitehead@...rochip.com,
	UNGLinuxDriver@...rochip.com, louis.peens@...igine.com,
	richardcochran@...il.com, linux-rdma@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-acenic@...site.dk,
	linux-arm-kernel@...ts.infradead.org, linuxppc-dev@...ts.ozlabs.org,
	linux-mediatek@...ts.infradead.org, oss-drivers@...igine.com,
	linux-net-drivers@....com
Subject: Re: [PATCH 1/1] [RFC] ethernet: Convert from tasklet to BH workqueue

On Tue, May 07, 2024 at 07:01:11PM +0000, Allen Pais wrote:
> The only generic interface to execute asynchronously in the BH context is
> tasklet; however, it's marked deprecated and has some design flaws. To
> replace tasklets, BH workqueue support was recently added. A BH workqueue
> behaves similarly to regular workqueues except that the queued work items
> are executed in the BH context.
> 
> This patch converts drivers/ethernet/* from tasklet to BH workqueue.

I doubt you're going to get many comments on this patch, being so large
and spread across all drivers. I'm not going to bother trying to edit
this down to something more sensible, I'll just plonk my comment here.

For the mvpp2 driver, you're only updating a comment - and looking at
it, the comment no longer reflects the code. It doesn't make use of
tasklets at all. That makes the comment wrong whether or not it's
updated. So I suggest rather than doing a search and replace for
"tasklet" to "BH blahblah" (sorry, I don't remember what you replaced
it with) just get rid of that bit of the comment.

Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!