netdev - Re: [Intel-wired-lan] [PATCH] igc: fix a log entry using uninitialized netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3d224a03-094d-4ae3-a471-cca7218bd732@linux.intel.com>
Date: Tue, 7 May 2024 12:00:38 +0300
From: "naamax.meir" <naamax.meir@...ux.intel.com>
To: Corinna Vinschen <vinschen@...hat.com>, netdev@...r.kernel.org,
 intel-wired-lan@...ts.osuosl.org
Subject: Re: [Intel-wired-lan] [PATCH] igc: fix a log entry using
 uninitialized netdev

On 4/23/2024 13:24, Corinna Vinschen wrote:
> During successful probe, igc logs this:
> 
> [    5.133667] igc 0000:01:00.0 (unnamed net_device) (uninitialized): PHC added
>                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> The reason is that igc_ptp_init() is called very early, even before
> register_netdev() has been called. So the netdev_info() call works
> on a partially uninitialized netdev.
> 
> Fix this by calling igc_ptp_init() after register_netdev(), right
> after the media autosense check, just as in igb.  Add a comment,
> just as in igb.
> 
> Now the log message is fine:
> 
> [    5.200987] igc 0000:01:00.0 eth0: PHC added
> 
> Signed-off-by: Corinna Vinschen <vinschen@...hat.com>
> ---
>   drivers/net/ethernet/intel/igc/igc_main.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)

Tested-by: Naama Meir <naamax.meir@...ux.intel.com>