netdev - Re: [PATCH net v5 2/4] ax25: Fix reference count leak issues of ax25

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4c09a28c-0336-4440-94c3-15337726ccd4@web.de>
Date: Tue, 7 May 2024 11:12:47 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Dan Carpenter <dan.carpenter@...aro.org>,
 Duoming Zhou <duoming@....edu.cn>, linux-hams@...r.kernel.org,
 netdev@...r.kernel.org, kernel-janitors@...r.kernel.org
Cc: "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Jörg Reuter <jreuter@...na.de>,
 Paolo Abeni <pabeni@...hat.com>, LKML <linux-kernel@...r.kernel.org>,
 Lars Kellogg-Stedman <lars@...bit.com>, Simon Horman <horms@...nel.org>
Subject: Re: [PATCH net v5 2/4] ax25: Fix reference count leak issues of
 ax25_dev

> The ax25_addr_ax25dev() and ax25_dev_device_down() exist a reference
> count leak issue of the object "ax25_dev".

Please improve this wording.

Suggestion:
   Two function implementations contained programming mistakes.
   Thus …

> Memory leak issue in ax25_addr_ax25dev():
>
> The reference count of the object "ax25_dev" can be increased multiple
> times in ax25_addr_ax25dev(). This will cause a memory leak so far.
…

* How do you think about to work with indentation in such a description
  for item enumeration?

* Would you like to add imperative wordings for improved changelogs?
  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9-rc7#n94

Regards,
Markus