netdev - Re: [PATCH v2 net-next] phonet: no longer hold RTNL in route

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240508124046.GD1736038@kernel.org>
Date: Wed, 8 May 2024 13:40:46 +0100
From: Simon Horman <horms@...nel.org>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, eric.dumazet@...il.com,
	Remi Denis-Courmont <courmisch@...il.com>
Subject: Re: [PATCH v2 net-next] phonet: no longer hold RTNL in route_dumpit()

On Tue, May 07, 2024 at 12:17:48PM +0000, Eric Dumazet wrote:
> route_dumpit() already relies on RCU, RTNL is not needed.
> 
> Also change return value at the end of a dump.
> This allows NLMSG_DONE to be appended to the current
> skb at the end of a dump, saving a couple of recvmsg()
> system calls.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Remi Denis-Courmont <courmisch@...il.com>
> ---
> v2: break;; -> break; (Jakub)

Reviewed-by: Simon Horman <horms@...nel.org>