[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <51b6a4f8-ef48-400f-acb6-fd20e661802d@lunn.ch>
Date: Wed, 8 May 2024 16:00:21 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Niklas Söderlund <niklas.soderlund+renesas@...natech.se>
Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
netdev@...r.kernel.org, linux-renesas-soc@...r.kernel.org
Subject: Re: [net-next,v2] net: ethernet: rtsn: Add support for Renesas
Ethernet-TSN
> I agree it's odd and I will try to find out.
>
> If I remove all pm_ calls and the include of pm_runtime.h register reads
> from the device do no longer works, so operating the device fails. Even
> if I dig out the root cause for this, is there any harm in keeping the
> pm_ operations in the initial entablement?
It suggests something is broken. Do we want to merge broken code?
Once we understand the root cause maybe then we can decide it is O.K.
Andrew
Powered by blists - more mailing lists