netdev - Re: [PATCH net-next v12 2/4] ethtool: provide customized dim profile management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240508081139.0a620321@kernel.org>
Date: Wed, 8 May 2024 08:11:39 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Heng Qi <hengqi@...ux.alibaba.com>
Cc: netdev@...r.kernel.org, virtualization@...ts.linux.dev, "David S . 
 Miller" <davem@...emloft.net>, Paolo Abeni <pabeni@...hat.com>, Eric 
 Dumazet <edumazet@...gle.com>, Jason Wang <jasowang@...hat.com>, "Michael S
  . Tsirkin" <mst@...hat.com>, Brett Creeley <bcreeley@....com>, Ratheesh 
 Kannoth <rkannoth@...vell.com>, Alexander Lobakin
 <aleksander.lobakin@...el.com>, Xuan Zhuo <xuanzhuo@...ux.alibaba.com>, Tal
  Gilboa <talgi@...dia.com>, Jonathan Corbet <corbet@....net>,
 linux-doc@...r.kernel.org, Maxime Chevallier
 <maxime.chevallier@...tlin.com>, Jiri Pirko <jiri@...nulli.us>, Paul 
 Greenwalt <paul.greenwalt@...el.com>, Ahmed Zaki <ahmed.zaki@...el.com>,
 Vladimir Oltean <vladimir.oltean@....com>, Kory Maincent
 <kory.maincent@...tlin.com>, Andrew Lunn <andrew@...n.ch>,
 justinstitt@...gle.com, Simon Horman <horms@...nel.org>
Subject: Re: [PATCH net-next v12 2/4] ethtool: provide customized dim
 profile management

On Wed, 8 May 2024 21:26:46 +0800 Heng Qi wrote:
> On Tue, 7 May 2024 19:57:52 -0700, Jakub Kicinski <kuba@...nel.org> wrote:
> > On Sat,  4 May 2024 14:44:45 +0800 Heng Qi wrote:  
> > > @@ -1325,6 +1354,8 @@ operations:
> > >              - tx-aggr-max-bytes
> > >              - tx-aggr-max-frames
> > >              - tx-aggr-time-usecs
> > > +            - rx-profile
> > > +            - tx-profil
> > >        dump: *coalesce-get-op
> > >      -
> > >        name: coalesce-set  
> > 
> > set probably needs to get the new attributes, too?  
> 
> I looked at other similar use cases (such as wol, debug) and it doesn't
> seem to be needed?

Sorry, you're right, they are propagated using a YAML alias.

> > > +static int ethnl_update_profile(struct net_device *dev,
> > > +				struct dim_cq_moder __rcu **dst,
> > > +				const struct nlattr *nests,
> > > +				struct netlink_ext_ack *extack)  
> >   
> > > +	rcu_assign_pointer(*dst, new_profile);
> > > +	kfree_rcu(old_profile, rcu);
> > > +
> > > +	return 0;  
> > 
> > Don't we need to inform DIM somehow that profile has switched
> > and it should restart itself?  
> 
> When the profile is modified, dim itself is a dynamic adjustment mechanism
> and will quickly adjust to the appropriate value according to the new profile.
> This is also seen in practice.

Okay, perhaps add a comment to that effect?