netdev - Re: [PATCH net-next v12 0/4] ethtool: provide the dim profile fine-tuning channel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 8 May 2024 23:53:29 +0800
From: Heng Qi <hengqi@...ux.alibaba.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org,
 "David S . Miller" <davem@...emloft.net>,
 Paolo  Abeni <pabeni@...hat.com>,
 Eric Dumazet <edumazet@...gle.com>,
 Jason Wang <jasowang@...hat.com>,
 "Michael S . Tsirkin" <mst@...hat.com>,
 Brett  Creeley <bcreeley@....com>,
 Ratheesh Kannoth <rkannoth@...vell.com>,
 Alexander Lobakin <aleksander.lobakin@...el.com>,
 Xuan Zhuo <xuanzhuo@...ux.alibaba.com>,
 Tal Gilboa <talgi@...dia.com>,
 Jonathan  Corbet <corbet@....net>,
 linux-doc@...r.kernel.org,
 Maxime Chevallier <maxime.chevallier@...tlin.com>,
 Jiri Pirko <jiri@...nulli.us>,
 Paul  Greenwalt <paul.greenwalt@...el.com>,
 Ahmed Zaki <ahmed.zaki@...el.com>,
 Vladimir Oltean <vladimir.oltean@....com>,
 Kory Maincent <kory.maincent@...tlin.com>,
 Andrew Lunn <andrew@...n.ch>,
 justinstitt@...gle.com,
 Simon Horman <horms@...nel.org>,
 virtualization@...ts.linux.dev
Subject: Re: [PATCH net-next v12 0/4] ethtool: provide the dim profile fine-tuning channel

On Tue, 7 May 2024 19:47:07 -0700, Jakub Kicinski <kuba@...nel.org> wrote:
> On Wed, 8 May 2024 10:12:35 +0800 Heng Qi wrote:
> > I would like to confirm if there are still comments on the current version,
> > since the current series and the just merged "Remove RTNL lock protection of
> > CVQ" conflict with a line of code with the fourth patch, if I can collect
> > other comments or ack/review tags, then release the new version seems better.
> 
> Looking now!
> 
> Please note that I merged a patch today which makes DIMLIB a tri-state
> config, meaning it can be a module now. So please double check that
> didn't break things, especially referring to dim symbols from the core
> code.

The transition from bool-state to tri-state has no impact on this series,
since functions in the DIM library used by external modules require
EXPORT_SYMBOL in both conditions.

Thanks.