netdev - Re: [PATCH net-next v2 10/10] gve: Implement queue api

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHS8izO4EjXB4U=oq0zFTdJRnqXPzRJLo9fVqtSHPAFnKoU9aQ@mail.gmail.com>
Date: Wed, 8 May 2024 10:09:29 -0700
From: Mina Almasry <almasrymina@...gle.com>
To: David Wei <dw@...idwei.uk>
Cc: Shailend Chand <shailend@...gle.com>, netdev@...r.kernel.org, davem@...emloft.net, 
	edumazet@...gle.com, hramamurthy@...gle.com, jeroendb@...gle.com, 
	kuba@...nel.org, pabeni@...hat.com, pkaligineedi@...gle.com, 
	rushilg@...gle.com, willemb@...gle.com, ziweixiao@...gle.com
Subject: Re: [PATCH net-next v2 10/10] gve: Implement queue api

On Tue, May 7, 2024 at 2:06 PM David Wei <dw@...idwei.uk> wrote:
>
> On 2024-05-06 11:47, Mina Almasry wrote:
> > On Mon, May 6, 2024 at 11:09 AM David Wei <dw@...idwei.uk> wrote:
> >>
> >> On 2024-05-01 16:25, Shailend Chand wrote:
> >>> The new netdev queue api is implemented for gve.
> >>>
> >>> Tested-by: Mina Almasry <almasrymina@...gle.com>
> >>> Reviewed-by:  Mina Almasry <almasrymina@...gle.com>
> >>> Reviewed-by: Praveen Kaligineedi <pkaligineedi@...gle.com>
> >>> Reviewed-by: Harshitha Ramamurthy <hramamurthy@...gle.com>
> >>> Signed-off-by: Shailend Chand <shailend@...gle.com>
> >>> ---
> >>>  drivers/net/ethernet/google/gve/gve.h        |   6 +
> >>>  drivers/net/ethernet/google/gve/gve_dqo.h    |   6 +
> >>>  drivers/net/ethernet/google/gve/gve_main.c   | 177 +++++++++++++++++--
> >>>  drivers/net/ethernet/google/gve/gve_rx.c     |  12 +-
> >>>  drivers/net/ethernet/google/gve/gve_rx_dqo.c |  12 +-
> >>>  5 files changed, 189 insertions(+), 24 deletions(-)
> >>>
> >>
> >> [...]
> >>
> >>> +static const struct netdev_queue_mgmt_ops gve_queue_mgmt_ops = {
> >>> +     .ndo_queue_mem_size     =       sizeof(struct gve_rx_ring),
> >>> +     .ndo_queue_mem_alloc    =       gve_rx_queue_mem_alloc,
> >>> +     .ndo_queue_mem_free     =       gve_rx_queue_mem_free,
> >>> +     .ndo_queue_start        =       gve_rx_queue_start,
> >>> +     .ndo_queue_stop         =       gve_rx_queue_stop,
> >>> +};
> >>
> >> Shailend, Mina, do you have code that calls the ndos somewhere?
> >
> > I plan to rebase the devmem TCP series on top of these ndos and submit
> > that, likely sometime this week. The ndos should be used from an
> > updated version of [RFC,net-next,v8,04/14] netdev: support binding
> > dma-buf to netdevice
>
> Now that queue API ndos have merged, could you please send this as a
> separate series and put it somewhere where it can be re-used e.g.
> netdev_rx_queue.c?
>

Definitely happy to put it in a generic place like netdev_rx_queue.c
like you did, but slight pushback to putting it into its own series.
With the ndos merged finally, I can take our devmem TCP series out of
RFC and I am eager to do so. Making it dependent on a change that is
in another series means it must remain RFC.

What I can do here is put this change into its own patch in the devmem
TCP series. Once that is reviewed the maintainers may apply that patch
out of the series. I can also put it in its own series and keep devmem
TCP in RFC for now if you insist :D


-- 
Thanks,
Mina