netdev - Re: [RFC PATCH net-next v2 3/9] netdev: add netdev_rx_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 8 May 2024 10:13:27 -0700
From: Mina Almasry <almasrymina@...gle.com>
To: Simon Horman <horms@...nel.org>
Cc: David Wei <dw@...idwei.uk>, netdev@...r.kernel.org, 
	Michael Chan <michael.chan@...adcom.com>, Pavan Chebbi <pavan.chebbi@...adcom.com>, 
	Andy Gospodarek <andrew.gospodarek@...adcom.com>, 
	Adrian Alvarado <adrian.alvarado@...adcom.com>, Shailend Chand <shailend@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [RFC PATCH net-next v2 3/9] netdev: add netdev_rx_queue_restart()

On Tue, May 7, 2024 at 9:47 AM Simon Horman <horms@...nel.org> wrote:
>
> On Sun, May 05, 2024 at 05:41:14PM -0700, David Wei wrote:
> > On 2024-05-04 05:20, Simon Horman wrote:
> > > On Wed, May 01, 2024 at 09:54:04PM -0700, David Wei wrote:
> > >> From: Mina Almasry <almasrymina@...gle.com>
> > >>
> > >> Add netdev_rx_queue_restart() function to netdev_rx_queue.h. This is
> > >> taken from Mina's work in [1] with a slight modification of taking
> > >> rtnl_lock() during the queue stop and start ops.
> > >>
> > >> For bnxt specifically, if the firmware doesn't support
> > >> BNXT_RST_RING_SP_EVENT, then ndo_queue_stop() returns -EOPNOTSUPP and
> > >> the whole restart fails. Unlike bnxt_rx_ring_reset(), there is no
> > >> attempt to reset the whole device.
> > >>
> > >> [1]: https://lore.kernel.org/linux-kernel/20240403002053.2376017-6-almasrymina@google.com/#t
> > >>
> > >> Signed-off-by: David Wei <dw@...idwei.uk>
> > >
> > > nit: Mina's From line is above, but there is no corresponding Signed-off-by
> > >      line here.
> >
> > This patch isn't a clean cherry pick, I pulled the core logic of
> > netdev_rx_queue_restart() from the middle of another patch. In these
> > cases should I be manually adding Signed-off-by tag?
>
> As you asked:
>
> I think if the patch is materially Mina's work - lets say more than 80% -
> then a From line and a Signed-off-by tag is appropriate. N.B. this
> implies Mina supplied a Signed-off-by tag at some point.
>
> Otherwise I think it's fine to drop both the From line and Signed-off-by tag.
> And as a courtesy acknowledge Mina's work some other way.
>
> e.g. based on work by Mina Almasry <almasrymina@...gle.com>
>
> But perhaps it's as well to as Mina what he thinks :)
>

I'm fine with whatever here. This work is mostly off of Jakub's design
anyway. Either Signed-off-by or Suggested-by or 'based on work by' is
fine with me.

However from the other thread, it looks like David is delegating me to
send follow up versions of this, possibly with the Devmem TCP series,
which works better for me anyway :D

-- 
Thanks,
Mina