netdev - Re: [PATCH net-next v5 3/6] net: tn40xx: add basic Tx handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 09 May 2024 08:03:55 +0900 (JST)
From: FUJITA Tomonori <fujita.tomonori@...il.com>
To: hfdevel@....net
Cc: fujita.tomonori@...il.com, netdev@...r.kernel.org, andrew@...n.ch,
 horms@...nel.org, kuba@...nel.org, jiri@...nulli.us, pabeni@...hat.com
Subject: Re: [PATCH net-next v5 3/6] net: tn40xx: add basic Tx handling

Hi,

Thanks for reviewing!

On Wed, 8 May 2024 19:46:05 +0200
Hans-Frieder Vogt <hfdevel@....net> wrote:

>> +#define TN40_SHORT_PACKET_SIZE 60
>> +#define TN40_FIRMWARE_NAME "tn40xx-14.fw"
> 
> why is here a new firmware name defined?
> The TN4010 uses the identical firmware as the tehuti ethernet
> driver. I
> suggest therefore to define instead, in order to avoid storing the
> same
> firmware twice:
> 
> #define TN40_FIRMWARE_NAME "tehuti/bdx.bin"

Ah, I overlooked the firmware for TN30xx. But TN40xx and TN30xx use
the identical firmware? On my environment, seems that they are
different.

$ cmp tn40xx-14.fw tehuti/bdx.bin
tn40xx-14.fw tehuti/bdx.bin differ: byte 21, line 1