netdev - Re: [PATCH net-next 0/1] mlx5: Add netdev-genl queue stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <05317efb-14e9-433b-b0b6-657a98500efd@gmail.com>
Date: Thu, 9 May 2024 12:42:11 +0300
From: Tariq Toukan <ttoukan.linux@...il.com>
To: Joe Damato <jdamato@...tly.com>
Cc: Jakub Kicinski <kuba@...nel.org>, Zhu Yanjun <zyjzyj2000@...il.com>,
 linux-kernel@...r.kernel.org, netdev@...r.kernel.org, saeedm@...dia.com,
 gal@...dia.com, nalramli@...tly.com, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Leon Romanovsky <leon@...nel.org>,
 "open list:MELLANOX MLX5 core VPI driver" <linux-rdma@...r.kernel.org>,
 Paolo Abeni <pabeni@...hat.com>, Tariq Toukan <tariqt@...dia.com>
Subject: Re: [PATCH net-next 0/1] mlx5: Add netdev-genl queue stats

..

>> The off-channels queues (like PTP) do not exist in default. So they are out
>> of the game unless you explicitly enables them.
> 
> I did not enable them, but if you saw the thread, it sounds like Jakub's
> preference is that in the v2 I include the PTP stats in get_base_stats.
> 
> Are you OK with that?

Sounds good.

> Are there other queue stats I should include as well?
> 

The QOS/HTB queues.
See mlx5e_stats_grp_sw_update_stats_qos.

>> A possible reason for this difference is the queues included in the sum.
>> Our stats are persistent across configuration changes, so they doesn't reset
>> when number of channels changes for example.
>>
>> We keep stats entries for al ring indices that ever existed. Our driver
>> loops and sums up the stats for all of them, while the stack loops only up
>> to the current netdev->real_num_rx_queues.
>>
>> Can this explain the diff here?
> 
> Yes, that was it. Sorry I didn't realize this case. My lab machine runs a
> script to adjust the queue count shortly after booting.
> 
> I disabled that and re-ran:
> 
>    NETIF=eth0 tools/testing/selftests/drivers/net/stats.py
> 
> and all tests pass.
> 

Great!