netdev - Re: [PATCH net-next v12 01/15] net: stmmac: Move the atds flag to the stmmac_dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c591f1ef-7540-4713-8e98-ce6f466efeb0@loongson.cn>
Date: Thu, 9 May 2024 20:44:01 +0800
From: Yanteng Si <siyanteng@...ngson.cn>
To: Serge Semin <fancer.lancer@...il.com>
Cc: andrew@...n.ch, hkallweit1@...il.com, peppe.cavallaro@...com,
 alexandre.torgue@...s.st.com, joabreu@...opsys.com, Jose.Abreu@...opsys.com,
 chenhuacai@...nel.org, linux@...linux.org.uk, guyinggang@...ngson.cn,
 netdev@...r.kernel.org, chris.chenfeiyang@...il.com, siyanteng01@...il.com
Subject: Re: [PATCH net-next v12 01/15] net: stmmac: Move the atds flag to the
 stmmac_dma_cfg structure


在 2024/5/3 03:10, Serge Semin 写道:
> "ATDS (Alternate Descriptor Size) is a part of the DMA Bus Mode configs
> (together with PBL, ALL, EME, etc) of the DW GMAC controllers. Seeing
> it's not changed at runtime but is activated as long as the IP-core
> has it supported (at least due to the Type 2 Full Checksum Offload
> Engine feature), move the respective parameter from the
> stmmac_dma_ops::init() callback argument to the stmmac_dma_cfg
> structure, which already have the rest of the DMA-related configs
> defined.
>
> Besides the being added in the next commit DW GMAC multi-channels
> support will require to add the stmmac_dma_ops::init_chan() callback
> and have the ATDS flag set/cleared for each channel in there. Having
> the atds-flag in the stmmac_dma_cfg structure will make the parameter
> accessible from stmmac_dma_ops::init_chan() callback too."
>
> Other than that the change looks good. Thanks.
>
> Reviewed-by: Serge Semin<fancer.lancer@...il.com>

Ok, I'll pick them up, thanks for your comment.


Thanks,

Yanteng