netdev - Re: [PATCH net-next 1/2] netdev: Add queue stats for TX stop and wake

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1b16210a-c0dd-4b79-88ac-d7cec2381e11@lunn.ch>
Date: Thu, 9 May 2024 22:46:30 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Daniel Jurgens <danielj@...dia.com>
Cc: netdev@...r.kernel.org, mst@...hat.com, jasowang@...hat.com,
	xuanzhuo@...ux.alibaba.com, virtualization@...ts.linux.dev,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, jiri@...dia.com
Subject: Re: [PATCH net-next 1/2] netdev: Add queue stats for TX stop and wake

On Thu, May 09, 2024 at 11:32:15AM -0500, Daniel Jurgens wrote:
> TX queue stop and wake are counted by some drivers.
> Support reporting these via netdev-genl queue stats.
> 
> Signed-off-by: Daniel Jurgens <danielj@...dia.com>
> Reviewed-by: Jiri Pirko <jiri@...dia.com>
> ---
>  Documentation/netlink/specs/netdev.yaml | 10 ++++++++++
>  include/net/netdev_queues.h             |  3 +++
>  include/uapi/linux/netdev.h             |  2 ++
>  net/core/netdev-genl.c                  |  4 +++-
>  tools/include/uapi/linux/netdev.h       |  3 ++-
>  5 files changed, 20 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/netlink/specs/netdev.yaml b/Documentation/netlink/specs/netdev.yaml
> index 2be4b3714d17..c8b976d03330 100644
> --- a/Documentation/netlink/specs/netdev.yaml
> +++ b/Documentation/netlink/specs/netdev.yaml
> @@ -439,6 +439,16 @@ attribute-sets:
>            Number of the packets dropped by the device due to the transmit
>            packets bitrate exceeding the device rate limit.
>          type: uint
> +      -
> +        name: tx-stop
> +        doc: |
> +          Number of times the tx queue was stopped.
> +        type: uint
> +      -
> +        name: tx-wake
> +        doc: |
> +          Number of times the tx queue was restarted.
> +        type: uint

I'm curious where these names came from. The opposite of stop would be
start. The opposite of wake would be sleep. Are these meant to be
opposites of each other? If they are opposites, why would they differ
by more than 1? And if they can only differ by 1, why do we need both?

	Andrew