netdev - Re: [PATCH] net: smc91x: Fix m68k kernel compilation for ColdFire CPU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 9 May 2024 23:26:46 +0200
From: Thorsten Blum <thorsten.blum@...lux.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: Nicolas Pitre <nico@...xnic.net>,
 "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>,
 John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>,
 Arnd Bergmann <arnd@...db.de>,
 netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: smc91x: Fix m68k kernel compilation for ColdFire CPU

On 9. May 2024, at 22:36, Andrew Lunn <andrew@...n.ch> wrote:
> This seems like the wrong fix.
> 
> commit d97cf70af09721ef416c61faa44543e3b84c9a55
> Author: Greg Ungerer <gerg@...ux-m68k.org>
> Date:   Fri Mar 23 23:39:10 2018 +1000
> 
>    m68k: use asm-generic/io.h for non-MMU io access functions
> 
>    There is nothing really special about the non-MMU m68k IO access functions.
>    So we can easily switch to using the asm-generic/io.h functions.
> 
> So it rather than put something back which there is an aim to remove,
> please find the generic replacement. This _swapw() swaps a 16 bit
> word. The generic for that is swab16().

Thanks. I will use ioread16be() and iowrite16be() as suggested by Arnd
instead and submit a v2 shortly.

Thorsten