netdev - Re: [PATCH net v6 1/3] ax25: Use kernel universal linked list to implement ax25_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240509031253.GA1077013@maili.marvell.com>
Date: Thu, 9 May 2024 08:42:53 +0530
From: Ratheesh Kannoth <rkannoth@...vell.com>
To: Duoming Zhou <duoming@....edu.cn>
CC: <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-hams@...r.kernel.org>, <pabeni@...hat.com>, <kuba@...nel.org>,
        <edumazet@...gle.com>, <davem@...emloft.net>, <jreuter@...na.de>,
        <dan.carpenter@...aro.org>
Subject: Re: [PATCH net v6 1/3] ax25: Use kernel universal linked list to
 implement ax25_dev_list

On 2024-05-09 at 07:26:12, Duoming Zhou (duoming@....edu.cn) wrote:
>  		if (ax25cmp(addr, (const ax25_address *)ax25_dev->dev->dev_addr) == 0) {
>  			res = ax25_dev;
>  			ax25_dev_hold(ax25_dev);
> @@ -52,6 +53,9 @@ void ax25_dev_device_up(struct net_device *dev)
>  {
>  	ax25_dev *ax25_dev;
>
> +	/* Initialized the list for the first entry */
> +	if (!ax25_dev_list.next)
will there be any case where this condition is true ? LIST_HEAD() or list_del() will never
make this condition true.

> +		INIT_LIST_HEAD(&ax25_dev_list);
>  	ax25_dev = kzalloc(sizeof(*ax25_dev), GFP_KERNEL);
>