netdev - RE: [PATCH net-next 1/2] netdev: Add queue stats for TX stop and wake

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 10 May 2024 03:37:36 +0000
From: Dan Jurgens <danielj@...dia.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "mst@...hat.com"
	<mst@...hat.com>, "jasowang@...hat.com" <jasowang@...hat.com>,
	"xuanzhuo@...ux.alibaba.com" <xuanzhuo@...ux.alibaba.com>,
	"virtualization@...ts.linux.dev" <virtualization@...ts.linux.dev>,
	"davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "pabeni@...hat.com" <pabeni@...hat.com>, Jiri Pirko
	<jiri@...dia.com>
Subject: RE: [PATCH net-next 1/2] netdev: Add queue stats for TX stop and wake

> From: Jakub Kicinski <kuba@...nel.org>
> Sent: Thursday, May 9, 2024 8:31 PM
> To: Dan Jurgens <danielj@...dia.com>
> Cc: netdev@...r.kernel.org; mst@...hat.com; jasowang@...hat.com;
> xuanzhuo@...ux.alibaba.com; virtualization@...ts.linux.dev;
> davem@...emloft.net; edumazet@...gle.com; pabeni@...hat.com; Jiri
> Pirko <jiri@...dia.com>
> Subject: Re: [PATCH net-next 1/2] netdev: Add queue stats for TX stop and
> wake
> 
> On Thu, 9 May 2024 11:32:15 -0500 Daniel Jurgens wrote:
> > diff --git a/tools/include/uapi/linux/netdev.h
> > b/tools/include/uapi/linux/netdev.h
> > index cf24f1d9adf8..ccf6976b1693 100644
> > --- a/tools/include/uapi/linux/netdev.h
> > +++ b/tools/include/uapi/linux/netdev.h
> > @@ -164,7 +164,8 @@ enum {
> >  	NETDEV_A_QSTATS_TX_HW_GSO_BYTES,
> >  	NETDEV_A_QSTATS_TX_HW_GSO_WIRE_PACKETS,
> >  	NETDEV_A_QSTATS_TX_HW_GSO_WIRE_BYTES,
> > -	NETDEV_A_QSTATS_TX_HW_DROP_RATELIMITS,
> 
> Looks like an accidental removal?

Yes, thanks.

> 
> > +	NETDEV_A_QSTATS_TX_STOP,
> > +	NETDEV_A_QSTATS_TX_WAKE,
> 
> Since you'll have to respin let me nit pick on the docs, as I'm hoping that
> those will be comprehensible to users not only devs.
> 
> > +        name: tx-stop
> > +        doc: |
> > +          Number of times the tx queue was stopped.
> 
> How about:
> 
> 	Number of times driver paused accepting new tx packets
> 	from the stack to this queue, because the queue was full.
> 	Note that if BQL is supported and enabled on the device
> 	the networking stack will avoid queuing a lot of data at once.
> 
> > +        name: tx-wake
> > +        doc: |
> > +          Number of times the tx queue was restarted.
> 
> 	Number of times driver re-started accepting send
> 	requests to this queue from the stack.

Will update it. Thanks for the text!