netdev - Re: [RFC PATCH] net: introduce HW Rate Limiting Driver API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f95b057fc1a8800abf2e04eb08737f198d910e13.camel@redhat.com>
Date: Fri, 10 May 2024 09:58:58 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Naveen Mamindlapalli <naveenm@...vell.com>, "netdev@...r.kernel.org"
	 <netdev@...r.kernel.org>
Cc: Jakub Kicinski <kuba@...nel.org>, Jiri Pirko <jiri@...nulli.us>, Madhu
 Chittim <madhu.chittim@...el.com>, Sridhar Samudrala
 <sridhar.samudrala@...el.com>, Simon Horman <horms@...nel.org>, John
 Fastabend <john.fastabend@...il.com>, Sunil Kovvuri Goutham
 <sgoutham@...vell.com>, Jamal Hadi Salim <jhs@...atatu.com>
Subject: Re: [RFC PATCH] net: introduce HW Rate Limiting Driver API

On Fri, 2024-05-10 at 07:10 +0000, Naveen Mamindlapalli wrote:

> On Thursday, May 9, 2024 1:51 AM Paolo Abeni <pabeni@...hat.com> wrote:
[...]
> > +/**
> > + * enum net_shaper_scope - the different scopes where a shaper could be
> > attached
> > + * @NET_SHAPER_SCOPE_PORT:   The root shaper for the whole H/W.
> > + * @NET_SHAPER_SCOPE_NETDEV: The main shaper for the given network
> > device.
> > + * @NET_SHAPER_SCOPE_VF:     The shaper is attached to the given virtual
> > + * function.
> > + * @NET_SHAPER_SCOPE_QUEUE_GROUP: The shaper groups multiple
> > queues
> > +under the
> > + * same device.
> > + * @NET_SHAPER_SCOPE_QUEUE:  The shaper is attached to the given
> > device queue.
> > + *
> > + * NET_SHAPER_SCOPE_PORT and NET_SHAPER_SCOPE_VF are only
> > available on
> > + * PF devices, usually inside the host/hypervisor.
> 
> What is the difference between NET_SHAPER_SCOPE_VF and NET_SHAPER_SCOPE_NETDEV 
> from a VF traffic shaping perspective?

With NET_SHAPER_SCOPE_VF, the user can control VF-level shapers from
within the hypervisor.

With NET_SHAPER_SCOPE_NETDEV, the user will control whatever is really
under the gear of the given 'dev' struct: the PF-level shaper if the
user itself is within the hypervisor, or the relevant VF if the user is
within the VM.

Cheers,

Paolo