netdev - Re: [PATCH net-next] selftests: net: local_termination: annotate the expected failures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240510105843.qp4ns4y42bikfeyp@skbuf>
Date: Fri, 10 May 2024 13:58:43 +0300
From: Vladimir Oltean <vladimir.oltean@....com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com, shuah@...nel.org, petrm@...dia.com,
	liuhangbin@...il.com, bpoirier@...dia.com,
	linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net-next] selftests: net: local_termination: annotate the
 expected failures

On Thu, May 09, 2024 at 04:55:53PM -0700, Jakub Kicinski wrote:
> diff --git a/tools/testing/selftests/net/forwarding/local_termination.sh b/tools/testing/selftests/net/forwarding/local_termination.sh
> index c5b0cbc85b3e..4bba9c78db3e 100755
> --- a/tools/testing/selftests/net/forwarding/local_termination.sh
> +++ b/tools/testing/selftests/net/forwarding/local_termination.sh
> @@ -73,6 +73,10 @@ check_rcv()
>  	local pattern=$3
>  	local should_receive=$4
>  	local should_fail=
> +	local xfail_sw=$5
> +
> +	local kind=$(ip -j -d link show dev $if_name |
> +			 jq -r '.[].linkinfo.info_kind')
>  
>  	[ $should_receive = true ] && should_fail=0 || should_fail=1
>  	RET=0
> @@ -81,7 +85,14 @@ check_rcv()
>  
>  	check_err_fail "$should_fail" "$?" "reception"
>  
> -	log_test "$if_name: $type"
> +	# If not a SW interface, ignore the XFAIL allowance
> +	[ "$kind" != veth ] && [ "$kind" != bridge ] && xfail_sw=
> +
> +	if [ $RET -ne 0 ] && [ "$xfail_sw" == true ]; then
> +	    log_test_xfail "$if_name: $type"
> +	else
> +	    log_test "$if_name: $type"
> +	fi
>  }

I just wish IFF_UNICAST_FLT was available to user space.

Reviewed-by: Vladimir Oltean <vladimir.oltean@....com>
Tested-by: Vladimir Oltean <vladimir.oltean@....com>