netdev - Re: [PATCH net-next v2 13/14] net: qede: propagate extack through qede_flow_spec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240510113053.GP2347895@kernel.org>
Date: Fri, 10 May 2024 12:30:53 +0100
From: Simon Horman <horms@...nel.org>
To: Asbjørn Sloth Tønnesen <ast@...erby.net>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Manish Chopra <manishc@...vell.com>,
	Przemek Kitszel <przemyslaw.kitszel@...el.com>
Subject: Re: [PATCH net-next v2 13/14] net: qede: propagate extack through
 qede_flow_spec_validate()

On Wed, May 08, 2024 at 02:34:01PM +0000, Asbjørn Sloth Tønnesen wrote:
> Pass extack to qede_flow_spec_validate() when called in
> qede_flow_spec_to_rule().
> 
> Pass extack to qede_parse_actions().
> 
> Not converting qede_flow_spec_validate() to use extack for
> errors, as it's only called from qede_flow_spec_to_rule(),
> where extack is faked into a DP_NOTICE anyway, so opting to
> keep DP_VERBOSE/DP_NOTICE usage.
> 
> Only compile tested.
> 
> Signed-off-by: Asbjørn Sloth Tønnesen <ast@...erby.net>

Reviewed-by: Simon Horman <horms@...nel.org>