netdev - RE: [PATCH net v2 2/4] net: wangxun: fix to change Rx features

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <011501daa27d$703c9080$50b5b180$@trustnetic.com>
Date: Fri, 10 May 2024 09:57:39 +0800
From: Jiawen Wu <jiawenwu@...stnetic.com>
To: "'Simon Horman'" <horms@...nel.org>
Cc: <davem@...emloft.net>,
	<edumazet@...gle.com>,
	<kuba@...nel.org>,
	<pabeni@...hat.com>,
	<rmk+kernel@...linux.org.uk>,
	<andrew@...n.ch>,
	<netdev@...r.kernel.org>,
	<mengyuanlou@...-swift.com>,
	<duanqiangwen@...-swift.com>
Subject: RE: [PATCH net v2 2/4] net: wangxun: fix to change Rx features

> > diff --git a/drivers/net/ethernet/wangxun/libwx/wx_lib.c b/drivers/net/ethernet/wangxun/libwx/wx_lib.c
> > index 6fae161cbcb8..667a5675998c 100644
> > --- a/drivers/net/ethernet/wangxun/libwx/wx_lib.c
> > +++ b/drivers/net/ethernet/wangxun/libwx/wx_lib.c
> > @@ -2690,12 +2690,14 @@ int wx_set_features(struct net_device *netdev, netdev_features_t features)
> >  		wx->rss_enabled = false;
> >  	}
> >
> > +	netdev->features = features;
> > +
> 
> nit: I think it would be slightly nicer to place this
>      at the end of the function, just before return.
>      But it would make no difference to the logic,
>      so I don't feel strongly about this.

Thanks for your notice, but it does have to be written here.
Since 'netdev->features' will be checked in wx_set_rx_mode().

> 
> >  	if (changed &
> >  	    (NETIF_F_HW_VLAN_CTAG_RX |
> >  	     NETIF_F_HW_VLAN_STAG_RX))
> >  		wx_set_rx_mode(netdev);
> >
> > -	return 1;
> > +	return 0;
> >  }
> >  EXPORT_SYMBOL(wx_set_features);
> >
> > --
> > 2.27.0
> >
> >
>