netdev - Re: [net PATCH v5 2/2] net: stmmac: move the EST structure to struct stmmac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240511174112.GS2347895@kernel.org>
Date: Sat, 11 May 2024 18:41:12 +0100
From: Simon Horman <horms@...nel.org>
To: Xiaolei Wang <xiaolei.wang@...driver.com>
Cc: alexandre.torgue@...s.st.com, joabreu@...opsys.com, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	mcoquelin.stm32@...il.com, richardcochran@...il.com,
	bartosz.golaszewski@...aro.org, rohan.g.thomas@...el.com,
	rmk+kernel@...linux.org.uk, fancer.lancer@...il.com,
	ahalaney@...hat.com, netdev@...r.kernel.org,
	linux-stm32@...md-mailman.stormreply.com,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [net PATCH v5 2/2] net: stmmac: move the EST structure to struct
 stmmac_priv

On Fri, May 10, 2024 at 08:21:55PM +0800, Xiaolei Wang wrote:
> Move the EST structure to struct stmmac_priv, because the
> EST configs don't look like platform config, but EST is
> enabled in runtime with the settings retrieved for the TC
> TAPRIO feature also in runtime. So it's better to have the
> EST-data preserved in the driver private data instead of
> the platform data storage.
> 
> Signed-off-by: Xiaolei Wang <xiaolei.wang@...driver.com>

Patch 1/2 of this series is a fix for net, with a Fixes tag.
IMHO, it looks good.

This patch, however, is a clean-up/enhancement.
It doesn't have a Fixes tag, which is good.
But I think it should be targeted at net-next
(once patch 1/2 has been accepted into net, and
net has been merged into net-next; also, given the timing,
once net-next reopens as It's likely to close rather soon
for the merge window).

Perhaps it is possible for the maintainers to pick up
patch 1/2, leaving this patch as follow-up.

The above notwithstanding, this patch looks good to me.

Reviewed-by: Simon Horman <horms@...nel.org>

-- 
pw-bot: under-review