netdev - Re: [PATCH net] inet: fix inet_fill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e5c07c0b-306f-4b06-acbc-fed7dca68238@kernel.org>
Date: Fri, 10 May 2024 19:47:08 -0600
From: David Ahern <dsahern@...nel.org>
To: Eric Dumazet <edumazet@...gle.com>, "David S . Miller"
 <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org, eric.dumazet@...il.com,
 Yu Watanabe <watanabe.yu@...il.com>
Subject: Re: [PATCH net] inet: fix inet_fill_ifaddr() flags truncation

On 5/10/24 1:29 AM, Eric Dumazet wrote:
> I missed that (struct ifaddrmsg)->ifa_flags was only 8bits,
> while (struct in_ifaddr)->ifa_flags is 32bits.
> 
> Use a temporary 32bit variable as I did in set_ifa_lifetime()
> and check_lifetime().
> 
> Fixes: 3ddc2231c810 ("inet: annotate data-races around ifa->ifa_flags")
> Reported-by: Yu Watanabe <watanabe.yu@...il.com>
> Dianosed-by: Yu Watanabe <watanabe.yu@...il.com>
> Closes: https://github.com/systemd/systemd/pull/32666#issuecomment-2103977928
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> ---
>  net/ipv4/devinet.c | 13 ++++++++++---
>  1 file changed, 10 insertions(+), 3 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>