netdev - Re: [PATCH] net: usb: ax88179_178a: fix link status when link is set to down/up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240511152310.GL2347895@kernel.org>
Date: Sat, 11 May 2024 16:23:10 +0100
From: Simon Horman <horms@...nel.org>
To: Jose Ignacio Tornos Martinez <jtornosm@...hat.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, linux-usb@...r.kernel.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org, Isaac Ganoung <inventor500@...aldi.net>,
	Yongqin Liu <yongqin.liu@...aro.org>
Subject: Re: [PATCH] net: usb: ax88179_178a: fix link status when link is set
 to down/up

On Fri, May 10, 2024 at 11:08:28AM +0200, Jose Ignacio Tornos Martinez wrote:
> The idea was to keep only one reset at initialization stage in order to
> reduce the total delay, or the reset from usbnet_probe or the reset from
> usbnet_open.
> 
> I have seen that restarting from usbnet_probe is necessary to avoid doing
> too complex things. But when the link is set to down/up (for example to
> configure a different mac address) the link is not correctly recovered
> unless a reset is commanded from usbnet_open.
> 
> So, detect the initialization stage (first call) to not reset from
> usbnet_open after the reset from usbnet_probe and after this stage, always
> reset from usbnet_open too (when the link needs to be rechecked).
> 
> Apply to all the possible devices, the behavior now is going to be the same.
> 
> cc: stable@...r.kernel.org # 6.6+
> Fixes: 56f78615bcb1 ("net: usb: ax88179_178a: avoid writing the mac address before first reading")
> Reported-by: Isaac Ganoung <inventor500@...aldi.net>
> Reported-by: Yongqin Liu <yongqin.liu@...aro.org>
> Signed-off-by: Jose Ignacio Tornos Martinez <jtornosm@...hat.com>

Reviewed-by: Simon Horman <horms@...nel.org>