netdev - Re: [PATCH v4 04/11] tty: serdev: Add method to enable break flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3070ec70b2477560f205cc4c34dd84b320831365.camel@hexdev.de>
Date: Sun, 12 May 2024 15:08:08 +0200
From: Christoph Fritz <christoph.fritz@...dev.de>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: Jiri Slaby <jirislaby@...nel.org>, Simon Horman <horms@...nel.org>, Greg
 Kroah-Hartman <gregkh@...uxfoundation.org>, Marc Kleine-Budde
 <mkl@...gutronix.de>, Oliver Hartkopp <socketcan@...tkopp.net>, Vincent
 Mailhol <mailhol.vincent@...adoo.fr>,  "David S . Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
 <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Rob Herring
 <robh@...nel.org>,  Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Jiri Kosina <jikos@...nel.org>, Benjamin Tissoires
 <bentiss@...nel.org>, Sebastian Reichel <sre@...nel.org>, Linus Walleij
 <linus.walleij@...aro.org>, Andreas Lauser
 <andreas.lauser@...cedes-benz.com>, Jonathan Corbet <corbet@....net>, Pavel
 Pisa <pisa@....felk.cvut.cz>, linux-can@...r.kernel.org, Netdev
 <netdev@...r.kernel.org>,  devicetree@...r.kernel.org,
 linux-input@...r.kernel.org, linux-serial <linux-serial@...r.kernel.org>
Subject: Re: [PATCH v4 04/11] tty: serdev: Add method to enable break flags

On Fri, 2024-05-10 at 17:21 +0300, Ilpo Järvinen wrote:
> On Thu, 9 May 2024, Christoph Fritz wrote:
...
> > diff --git a/drivers/tty/serdev/core.c b/drivers/tty/serdev/core.c
> > index 613cb356b918d..23a1e76cb553b 100644
> > --- a/drivers/tty/serdev/core.c
> > +++ b/drivers/tty/serdev/core.c
> > @@ -339,6 +339,17 @@ unsigned int serdev_device_set_baudrate(struct serdev_device *serdev, unsigned i
> >  }
> >  EXPORT_SYMBOL_GPL(serdev_device_set_baudrate);
> >  
> > +void serdev_device_set_break_detection(struct serdev_device *serdev, bool enable)
> > +{
> > +	struct serdev_controller *ctrl = serdev->ctrl;
> > +
> > +	if (!ctrl || !ctrl->ops->set_break_detection)
> > +		return;
> 
> Why you need to test for !ctrl?

In our case we don't, it's an extra check like all the other functions
here:

https://elixir.bootlin.com/linux/v6.9-rc7/source/drivers/tty/serdev/core.c#L330

> 
> > +	ctrl->ops->set_break_detection(ctrl, enable);
> 
> I'd use positive logic here:
> 
> 	if (ctrl->ops->set_break_detection)
> 		ctrl->ops->set_break_detection(ctrl, enable);