netdev - Re: [PATCH net-next 2/3] net/mlx5e: Modifying channels number and updating TX queues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 13 May 2024 09:59:44 +0100
From: Simon Horman <horms@...nel.org>
To: Tariq Toukan <tariqt@...dia.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Eric Dumazet <edumazet@...gle.com>, netdev@...r.kernel.org,
	Saeed Mahameed <saeedm@...dia.com>, Gal Pressman <gal@...dia.com>,
	Leon Romanovsky <leonro@...dia.com>,
	Carolina Jubran <cjubran@...dia.com>
Subject: Re: [PATCH net-next 2/3] net/mlx5e: Modifying channels number and
 updating TX queues

On Sun, May 12, 2024 at 03:43:04PM +0300, Tariq Toukan wrote:
> From: Carolina Jubran <cjubran@...dia.com>
> 
> It is not appropriate for the mlx5e_num_channels_changed
> function to be called solely for updating the TX queues,
> even if the channels number has not been changed.
> 
> Move the code responsible for updating the TC and TX queues
> from mlx5e_num_channels_changed and produce a new function
> called mlx5e_update_tc_and_tx_queues. This new function should
> only be called when the channels number remains unchanged.
> 
> Signed-off-by: Carolina Jubran <cjubran@...dia.com>
> Signed-off-by: Tariq Toukan <tariqt@...dia.com>

Reviewed-by: Simon Horman <horms@...nel.org>